Repository navigation
fix(den-web): move My Usage under Work in the sidebar - #7448
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this about?
Den's sidebar: My Usage moves from Observability to Work, next to the member's other "My" pages.
What problem does it solve?
My Usage is a member's own page, but it sat in Observability with the admin-facing Analytics and Audit logs, so people looked for it in the wrong place.
What was the situation before?
Every member saw an Observability section holding My Usage. For a member without admin permissions it was the only item there.
How is this implemented?
ee/apps/den-web/app/(den)/dashboard/_lib/dashboard-navigation.ts: the My Usage entry moves from the Observability items to the Work items, after My Computers. Same route, icon and test id.What else changed?
my-usage-data.test.ts: asserts Work › My Usage and no empty Observability section.evals/proofs/member-usage-page.proof.test.ts: the first step now requires the link inside the Work section and no Observability section, and screenshots the sidebar.Release note
My Usage now appears under Work in the Den sidebar.
Evidence
Unit test and typecheck only:
my-usage-data.test.tschecks a regular member gets Work › My Usage and no Observability section. The updatedevals/proofs/member-usage-page.proof.test.tshas not been run: its setup needs a local test database, so it cannot run on Daytona.Design: C3, P10