Skip to content

fix(den-web): keep members without display names visible - #7449

Merged
yomgui merged 2 commits into
devfrom
fix/member-name-fallback
Nov 16, 2026
Merged

yomgui merged 2 commits into
devfrom
fix/member-name-fallback

Conversation

@yomgui

@yomgui yomgui commented Nov 16, 2026

Copy link
Copy Markdown
Member

What is this about?

The Den members list now shows every joined member, including people whose profile has no display name.

What problem does it solve?

Admins couldn't see some real members. Inviting one of them failed with "already a member", so the list and the invite flow disagreed.

What was the situation before?

A member who joined (for example through SSO) with an empty display name was missing from Members, from search and from team counts. Inviting their email was correctly refused as a duplicate.

How is this implemented?

  • ee/apps/den-web/app/(den)/_lib/den-org.ts: parseOrgContextPayload no longer rejects a member just because user.name is empty. A blank, whitespace-only or missing name falls back to the member's email. Member ID, role, user ID and email are still required.
  • The existing row and identity components already show email when the name equals the email, so no UI component changed.
  • No backend, auth, invitation or profile data changes; stored names are left as they are.

What else changed?

  • New colocated den-org.test.ts with parser regressions.

Release note

Members whose profile has no display name now appear in the Members list, shown by their email.

Evidence

ee/apps/den-web/app/(den)/_lib/den-org.test.ts. Before: ten joined members with five blank names parsed to five (5 !== 10). After: all ten are kept and the blank ones use their email; ordinary names, pending invitations, team references and required-field rejection are unchanged. No E2E for this change; the quick check typechecks the shipped parser.

Design: P1, P5

Signed-off-by: Guillaume Loret <guillaume@openworklabs.com>
Signed-off-by: Guillaume Loret <guillaume@openworklabs.com>
@vercel

vercel Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
openwork-den Ready Ready Preview Nov 16, 2026 10:36pm UTC
2 Skipped Deployments
Project Deployment Actions Updated
openwork-app Skipped Skipped Nov 16, 2026 10:36pm UTC
openwork-landing Skipped Skipped v0 Nov 16, 2026 10:36pm UTC

Request Review

@yomgui
yomgui merged commit 76328b2 into dev Nov 16, 2026
19 checks passed

This branch was successfully deployed

1 active and 2 inactive deployments
Preview – openwork-den — 2e2260b6 Deployed Nov 16, 2026 by vercel[bot]
Preview – openwork-landing — 2e2260b6 Deployed Nov 16, 2026 by vercel[bot]
Preview – openwork-app — 2e2260b6 Deployed Nov 16, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant