Repository navigation
fix(den-web): keep members without display names visible - #7449
Merged
Merged
Conversation
Signed-off-by: Guillaume Loret <guillaume@openworklabs.com>
Signed-off-by: Guillaume Loret <guillaume@openworklabs.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this about?
The Den members list now shows every joined member, including people whose profile has no display name.
What problem does it solve?
Admins couldn't see some real members. Inviting one of them failed with "already a member", so the list and the invite flow disagreed.
What was the situation before?
A member who joined (for example through SSO) with an empty display name was missing from Members, from search and from team counts. Inviting their email was correctly refused as a duplicate.
How is this implemented?
ee/apps/den-web/app/(den)/_lib/den-org.ts:parseOrgContextPayloadno longer rejects a member just becauseuser.nameis empty. A blank, whitespace-only or missing name falls back to the member's email. Member ID, role, user ID and email are still required.What else changed?
den-org.test.tswith parser regressions.Release note
Members whose profile has no display name now appear in the Members list, shown by their email.
Evidence
ee/apps/den-web/app/(den)/_lib/den-org.test.ts. Before: ten joined members with five blank names parsed to five (5 !== 10). After: all ten are kept and the blank ones use their email; ordinary names, pending invitations, team references and required-field rejection are unchanged. No E2E for this change; the quick check typechecks the shipped parser.Design: P1, P5