Skip to content

fix(mcp): stop blocking connections for sign-in server review - #7456

Closed
reachjalil wants to merge 1 commit into
devfrom
fix/mcp-no-issuer-review-hold
Closed

reachjalil wants to merge 1 commit into
devfrom
fix/mcp-no-issuer-review-hold

Conversation

@reachjalil

Copy link
Copy Markdown
Member

What is this about?

OAuth connections to provider MCP servers. Den no longer blocks a connection until an admin reviews its sign-in server.

What problem does it solve?

The block was meant for a provider whose sign-in server changed. It also fired on setup errors and on connections nobody had signed in to, and it never cleared, so a connection that tripped it stayed unusable.

What was the situation before?

A blocked connection showed as an error in search, refused every tool call, and offered admins a "Review sign-in server" action. Nothing else released it, even after the provider's sign-in information was consistent again.

How is this implemented?

  • Den API stops setting, reading and reporting oauth_issuer_review_required_at across persistence, capabilities, the per-connection route, the dashboard and sign-in routes, the Slack assistant and Workbot's app list.
  • The safety check is unchanged: packages/enterprise-mcp-client still refuses to send a sign-in or refresh to any authorization server but the selected one.
  • The connection API drops issuerReviewRequired; the authorization server review drops reviewRequired.
  • Den web drops the review action and notice. "Authorization server selection" stays.

What else changed?

  • The column stays, unused, until a later migration drops it; the readiness fingerprint keeps a null in its place.
  • The desktop app still reads the state, for older Den servers.
  • No feature flag: this removes a block that misfired.

Release note

Connections are no longer blocked until an admin reviews the sign-in server; a connection stuck in that state works again.

Evidence

ee/apps/den-api/test/api/mcp-connection-route-access.api.test.ts — before: a connection carrying the review mark refuses its tool as blocked; after: the tool runs. No E2E; the admin screens only lose a state that can no longer occur.

An OAuth connection could be marked as needing an administrator's
review of its sign-in server. While marked, search reported it as an
error, tool calls and the per-connection routes refused it, and nobody
could use it until an admin chose an authorization server in its
settings.

The mark was meant for a provider whose sign-in server changed. It was
set by any sign-in configuration error while saving discovery, on the
first reading, on connections nobody had signed in to, and it never
cleared by itself. It held connections that had never worked and left
them unusable after the provider's sign-in information was consistent
again.

It was also not what kept credentials safe. The client library checks,
every time it loads or saves discovery, that the authorization server
is the one selected for the connection, and refuses to send a sign-in
or a refresh anywhere else. That check is unchanged.

Den no longer sets, reads or reports the mark:

- A binding violation still drops the cached discovery, and the sign-in
  or call that hit it fails with its own error and can be retried.
- Search, execute_capability, the per-connection routes, scripts, the
  Slack assistant, Workbot's app list and the workflow library treat
  the connection like any other.
- The connection API no longer returns issuerReviewRequired, and the
  authorization server review no longer returns reviewRequired. Den web
  drops the "Review sign-in server" action and the notice that the
  sign-in server changed. Choosing an authorization server stays.
- A non-admin whose sign-in needs saved credentials cleared is still
  told to ask an admin.

The column oauth_issuer_review_required_at is left in place, unused,
so instances running during a rollout keep working; a later migration
drops it. The readiness fingerprint keeps a null in its place so saved
fingerprints still match. The desktop app still understands the state,
because older Den servers can send it.

A connection that carries the old mark runs its tool again; the test
for that goes through the real app.

Signed-off-by: Jalil <reachjalil@gmail.com>
@vercel

vercel Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
openwork-app Ready Ready Preview Nov 17, 2026 12:24am UTC
openwork-den Ready Ready Preview Nov 17, 2026 12:24am UTC
openwork-landing Ready Ready Preview, v0 Nov 17, 2026 12:24am UTC

Request Review

This branch was successfully deployed

3 active deployments
Preview – openwork-app — 1ab05df2 Deployed Nov 17, 2026 by vercel[bot]
Preview – openwork-landing — 1ab05df2 Deployed Nov 17, 2026 by vercel[bot]
Preview – openwork-den — 1ab05df2 Deployed Nov 17, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant