Repository navigation
release: v1.4.128 Gemini 授权启动修复 - #1170
Merged
Merged
Conversation
(cherry picked from commit 726c33b1cfd3d5d11a869ab1c4df5f364783ba7b)
Contributor
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: a2060b44-2021-43b7-86d1-48959e5d9aa3) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
变更
验证
Note
Medium Risk
Changes host firewall/nftables behavior during Gemini OAuth; rules are scoped and torn down, but mistakes could affect forwarding on Docker hosts.
Overview
Release v1.4.128 fixes Gemini Google OAuth startup on hosts where Docker’s default FORWARD policy blocks traffic (e.g. Ubuntu 22.04).
gemini-host-egress.shnow uses an nftables output NAT priority (-100) that works on those kernels, and whenDOCKER-USERexists it temporarily inserts scopediptablesrules so only the isolated veth, guest IP, and bound SOCKS5 address/port can forward—then removes them on stop. Startup is stricter (refuse double-start), and cleanup runs onEXITinstead of errors-only.Docs and CHANGELOG describe the Docker-forwarding behavior;
gemini-host-egress-smoke.shsimulatesFORWARD DROP+DOCKER-USERand asserts rule cleanup. The release note also bundles already-merged #1149 and #1168; no payload or slot reinstall required.Reviewed by Cursor Bugbot for commit 4cc7c1e. Configure here.