Skip to content

chore: Add logging to investigate issue that different CPU frequency is reported on windows(arm64) #3298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
filzrev wants to merge 1 commit into from
+26 −12
Closed

chore: Add logging to investigate issue that different CPU frequency is reported on windows(arm64) #3298

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 26 additions & 12 deletions tests/BenchmarkDotNet.IntegrationTests/Detectors/CpuDetectorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
using AwesomeAssertions;
using BenchmarkDotNet.Detectors;
using BenchmarkDotNet.Detectors.Cpu.Windows;
using BenchmarkDotNet.Helpers;
using BenchmarkDotNet.Tests.XUnit;
using Perfolizer.Helpers;
using Perfolizer.Models;
Expand Down Expand Up @@ -50,19 +51,32 @@ public void DetectCpuInfoOnWindowsAndCompareValues()
cpuInfo1.Should().NotBeNull();
cpuInfo2.Should().NotBeNull();

cpuInfo1.Should().BeEquivalentTo(cpuInfo2, options => options
.Using<long?>(ctx =>
{
if (ctx.Expectation is null)
try
{
cpuInfo1.Should().BeEquivalentTo(cpuInfo2, options => options
.Using<long?>(ctx =>
{
ctx.Subject.Should().BeNull();
return;
}
if (ctx.Expectation is null)
{
ctx.Subject.Should().BeNull();
return;
}

var expected = (double)ctx.Expectation!.Value;
var actual = (double)ctx.Subject!.Value;
var tolerance = Math.Abs(expected) * 0.02d; // Accept 2％ difference
actual.Should().BeApproximately(expected, tolerance);
}).WhenTypeIs<long?>());
var expected = (double)ctx.Expectation!.Value;
var actual = (double)ctx.Subject!.Value;
var tolerance = Math.Abs(expected) * 0.02d; // Accept 2％ difference
actual.Should().BeApproximately(expected, tolerance);
}).WhenTypeIs<long?>());
}
catch
{
// Print CPU frequency information that is recognized by Windows.
// See: https://github.com/dotnet/BenchmarkDotNet/issues/3285
var result = ProcessHelper.RunAndReadOutput("systeminfo");
Output.WriteLine(result);

// TODO: Suppress throw exception on specific environment. (`Cobalt 100 2.85GHz` on `windows(arm64)`)
throw;
}
}
}
Loading