Modernize C# code snippets - System/T* - #12972
Open
gewarren wants to merge 7 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the ECMA snippet sources under snippets/csharp/System/... to align with the “modernize C# code snippets” effort (Issue #12713), primarily by adopting newer C# idioms and refreshing formatting while keeping the samples functionally equivalent.
Changes:
- Modernizes snippet code style (e.g., string interpolation, target-typed
new, expression-bodied members, updated type keywords likedouble). - Cleans up formatting/whitespace in many snippets (indentation, blank lines, comment spacing).
- Removes some legacy patterns in output formatting (but see review comments for a couple of introduced formatting bugs).
Reviewed changes
Copilot reviewed 105 out of 125 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| snippets/csharp/System/TupleT1/ToString/tostring1.cs | Modernizes Tuple1 ToString` sample formatting. |
| snippets/csharp/System/TupleT1/System.Collections.IStructuralComparable.CompareTo/compareto2.cs | Modernizes CompareTo sample (types + interpolation). |
| snippets/csharp/System/TupleT1/System.Collections.IStructuralComparable.CompareTo/compareto1.cs | Modernizes CompareTo sample (types + interpolation). |
| snippets/csharp/System/TupleT1/Item1/item1.cs | Modernizes Item1 sample output formatting (interpolation). |
| snippets/csharp/System/TupleT1/Equals/equals2.cs | Modernizes Equals/structural equality sample formatting. |
| snippets/csharp/System/TupleT1/Equals/equals1.cs | Modernizes Equals sample formatting (interpolation). |
| snippets/csharp/System/TupleT1,T2/ToString/tostring1.cs | Modernizes Tuple2 ToString` sample formatting. |
| snippets/csharp/System/TupleT1,T2/System.Collections.IStructuralComparable.CompareTo/compareto2.cs | Modernizes Tuple`2 structural compare sample formatting. |
| snippets/csharp/System/TupleT1,T2/System.Collections.IStructuralComparable.CompareTo/compareto1.cs | Modernizes Tuple`2 compare sample formatting. |
| snippets/csharp/System/TupleT1,T2/Overview/item1.cs | Modernizes Tuple`2 overview/divide sample formatting. |
| snippets/csharp/System/TupleT1,T2/Overview/example1.cs | Modernizes Tuple`2 overview/mean sample formatting. |
| snippets/csharp/System/TupleT1,T2/Equals/equals2.cs | Modernizes Tuple`2 structural equals sample formatting. |
| snippets/csharp/System/TupleT1,T2/Equals/equals1.cs | Modernizes Tuple`2 equals sample formatting. |
| snippets/csharp/System/TupleT1,T2,T3/ToString/tostring1.cs | Modernizes Tuple3 ToString` sample formatting. |
| snippets/csharp/System/TupleT1,T2,T3/System.Collections.IStructuralComparable.CompareTo/compareto2.cs | Modernizes Tuple`3 structural compare sample formatting. |
| snippets/csharp/System/TupleT1,T2,T3/System.Collections.IStructuralComparable.CompareTo/compareto1.cs | Modernizes Tuple`3 compare sample formatting. |
| snippets/csharp/System/TupleT1,T2,T3/Overview/example1.cs | Modernizes Tuple`3 overview/statistics sample formatting. |
| snippets/csharp/System/TupleT1,T2,T3/Equals/equals2.cs | Modernizes Tuple`3 structural equals sample formatting. |
| snippets/csharp/System/TupleT1,T2,T3/Equals/equals1.cs | Modernizes Tuple`3 equals sample formatting. |
| snippets/csharp/System/TupleT1,T2,T3,T4/ToString/tostring1.cs | Modernizes Tuple4 ToString` sample formatting. |
| snippets/csharp/System/TupleT1,T2,T3,T4/System.Collections.IStructuralComparable.CompareTo/compareto2.cs | Modernizes Tuple`4 structural compare sample formatting. |
| snippets/csharp/System/TupleT1,T2,T3,T4/System.Collections.IStructuralComparable.CompareTo/compareto1.cs | Modernizes Tuple`4 compare sample formatting (cleanup usings/format). |
| snippets/csharp/System/TupleT1,T2,T3,T4/Overview/example1.cs | Modernizes Tuple`4 overview/statistics sample formatting. |
| snippets/csharp/System/TupleT1,T2,T3,T4/Item1/item1.cs | Modernizes Tuple`4 Item1 sample output formatting. |
| snippets/csharp/System/TupleT1,T2,T3,T4,T5/ToString/tostring1.cs | Modernizes Tuple5 ToString` sample formatting. |
| snippets/csharp/System/TupleT1,T2,T3,T4,T5/System.Collections.IStructuralComparable.CompareTo/compareto1.cs | Modernizes Tuple`5 compare sample formatting (cleanup usings/format). |
| snippets/csharp/System/TupleT1,T2,T3,T4,T5/Item1/item1.cs | Modernizes Tuple`5 Item1 sample output formatting. |
| snippets/csharp/System/TupleT1,T2,T3,T4,T5/Equals/equals2.cs | Modernizes Tuple`5 structural equals sample formatting. |
| snippets/csharp/System/TupleT1,T2,T3,T4,T5,T6/ToString/tostring1.cs | Modernizes Tuple6 ToString` sample formatting. |
| snippets/csharp/System/TupleT1,T2,T3,T4,T5,T6/System.Collections.IStructuralComparable.CompareTo/compareto1.cs | Modernizes Tuple`6 compare sample formatting. |
| snippets/csharp/System/TupleT1,T2,T3,T4,T5,T6/Overview/example1.cs | Modernizes Tuple`6 overview sample formatting. |
| snippets/csharp/System/TupleT1,T2,T3,T4,T5,T6/Item1/item1.cs | Modernizes Tuple`6 Item1 sample output formatting. |
| snippets/csharp/System/TupleT1,T2,T3,T4,T5,T6/Equals/equals1.cs | Modernizes Tuple`6 equals sample formatting. |
| snippets/csharp/System/TupleT1,T2,T3,T4,T5,T6,T7/ToString/tostring1.cs | Modernizes Tuple7 ToString` sample formatting. |
| snippets/csharp/System/TupleT1,T2,T3,T4,T5,T6,T7/System.Collections.IStructuralComparable.CompareTo/compareto1.cs | Modernizes Tuple`7 compare sample formatting. |
| snippets/csharp/System/TupleT1,T2,T3,T4,T5,T6,T7/Overview/example1.cs | Modernizes Tuple`7 overview sample formatting. |
| snippets/csharp/System/TupleT1,T2,T3,T4,T5,T6,T7/Item1/item1.cs | Modernizes Tuple`7 Item1 sample output formatting. |
| snippets/csharp/System/TupleT1,T2,T3,T4,T5,T6,T7/Equals/equals1.cs | Modernizes Tuple`7 equals sample formatting. |
| snippets/csharp/System/TupleT1,T2,T3,T4,T5,T6,T7,TRest/ToString/tostring1.cs | Modernizes TRest tuple ToString sample formatting. |
| snippets/csharp/System/TupleT1,T2,T3,T4,T5,T6,T7,TRest/System.Collections.IStructuralComparable.CompareTo/compareto1.cs | Modernizes TRest tuple compare sample formatting (types). |
| snippets/csharp/System/TupleT1,T2,T3,T4,T5,T6,T7,TRest/Overview/octuple1.cs | Modernizes octuple construction sample formatting. |
| snippets/csharp/System/TupleT1,T2,T3,T4,T5,T6,T7,TRest/Item1/item1.cs | Modernizes TRest tuple Item1 sample formatting/output. |
| snippets/csharp/System/TupleT1,T2,T3,T4,T5,T6,T7,TRest/Equals/equals1.cs | Modernizes TRest tuple equals sample formatting/output. |
| snippets/csharp/System/Tuple/Overview/example1.cs | Modernizes Tuple overview sample (Ctor vs Create) output formatting. |
| snippets/csharp/System/Tuple/Overview/example.cs | Modernizes Tuple nested-TRest sample formatting/output. |
| snippets/csharp/System/Tuple/Overview/ctor8.cs | Modernizes Tuple ctor sample formatting. |
| snippets/csharp/System/Tuple/Overview/createntuple.cs | Modernizes Tuple.Create n-tuple sample formatting. |
| snippets/csharp/System/TimeZoneInfo/HasSameRules/HasSameRules.cs | Modernizes HasSameRules sample formatting and output. |
| snippets/csharp/System/TimeZoneInfo/Equals/equals1.cs | Modernizes Equals sample formatting. |
| snippets/csharp/System/TimeZoneInfo/ConvertTimeBySystemTimeZoneId/convertdt2.cs | Modernizes ConvertTimeBySystemTimeZoneId sample output formatting. |
| snippets/csharp/System/TimeZoneInfo/ConvertTime/converttime2.cs | Modernizes DateTimeOffset conversion sample formatting/output. |
| snippets/csharp/System/TimeZoneInfo/ConvertTime/converttime1.cs | Modernizes DateTime conversion sample formatting/output. |
| snippets/csharp/System/TimeZoneInfo/ClearCachedData/System.TimeZone2.BestPractices.cs | Modernizes ClearCachedData best-practices snippet formatting. |
| snippets/csharp/System/TimeZoneInfo/BaseUtcOffset/ShowTimeZoneNames1.cs | Modernizes BaseUtcOffset sample output formatting. |
| snippets/csharp/System/TimeSpan/TryParseExact/tryparseexactexample4.cs | Modernizes TryParseExact sample formatting/output. |
| snippets/csharp/System/TimeSpan/TryParseExact/tryparseexactexample3.cs | Modernizes TryParseExact sample formatting/output. |
| snippets/csharp/System/TimeSpan/TryParse/tryparse2.cs | Modernizes TryParse sample table output formatting. |
| snippets/csharp/System/TimeSpan/TryParse/TryParse1.cs | Modernizes TryParse walkthrough sample formatting/output. |
| snippets/csharp/System/TimeSpan/TotalSeconds/totalseconds.cs | Modernizes TotalSeconds sample output formatting. |
| snippets/csharp/System/TimeSpan/TotalMinutes/totalminutes.cs | Modernizes TotalMinutes sample output formatting. |
| snippets/csharp/System/TimeSpan/TotalMilliseconds/totalmilliseconds.cs | Modernizes TotalMilliseconds sample output formatting. |
| snippets/csharp/System/TimeSpan/TotalHours/totalhours.cs | Modernizes TotalHours sample output formatting. |
| snippets/csharp/System/TimeSpan/TotalDays/totaldays.cs | Modernizes TotalDays sample output formatting. |
| snippets/csharp/System/TimeSpan/ToString/tostring4.cs | Modernizes ToString format/culture sample table formatting. |
| snippets/csharp/System/TimeSpan/ToString/ToString1.cs | Modernizes TimeSpan ToString initialization sample formatting. |
| snippets/csharp/System/TimeSpan/Subtract/subtract1.cs | Modernizes Subtract sample formatting. |
| snippets/csharp/System/TimeSpan/ParseExact/parseexactexample4.cs | Modernizes ParseExact sample formatting/output. |
| snippets/csharp/System/TimeSpan/ParseExact/parseexactexample3.cs | Modernizes ParseExact sample formatting/output. |
| snippets/csharp/System/TimeSpan/Parse/parse2.cs | Modernizes Parse sample (multi-culture) formatting/output. |
| snippets/csharp/System/TimeSpan/Parse/parse1.cs | Modernizes Parse sample (CurrentCulture) formatting/output. |
| snippets/csharp/System/TimeSpan/Overview/zero1.cs | Modernizes overview sample (target-typed new, expression-bodied locals). |
| snippets/csharp/System/TimeSpan/op_Equality/relationalops.cs | Modernizes relational operators demo formatting. |
| snippets/csharp/System/TimeSpan/op_Addition/Subtraction1.cs | Modernizes addition/subtraction operators sample formatting/output. |
| snippets/csharp/System/TimeSpan/op_Addition/operators1.cs | Modernizes addition operators sample formatting/output. |
| snippets/csharp/System/TimeSpan/MaxValue/fields.cs | Modernizes fields demo formatting (spacing, string interpolation). |
| snippets/csharp/System/TimeSpan/FromDays/System.TimeSpan.FromMinutes.cs | Modernizes FromX overflow snippet formatting. |
| snippets/csharp/System/TimeSpan/FromDays/fromticks.cs | Modernizes FromTicks demo formatting/output. |
| snippets/csharp/System/TimeSpan/FromDays/fromseconds.cs | Modernizes FromSeconds demo formatting/output. |
| snippets/csharp/System/TimeSpan/FromDays/fromminutes.cs | Modernizes FromMinutes demo formatting/output. |
| snippets/csharp/System/TimeSpan/FromDays/frommillisec.cs | Modernizes FromMilliseconds demo formatting/output. |
| snippets/csharp/System/TimeSpan/FromDays/fromhours.cs | Modernizes FromHours demo formatting/output. |
| snippets/csharp/System/TimeSpan/FromDays/fromdays.cs | Modernizes FromDays demo formatting/output. |
| snippets/csharp/System/TimeSpan/Duration/dura_nega_una.cs | Modernizes Duration/Negate demo formatting/output. |
| snippets/csharp/System/TimeSpan/Days/properties.cs | Modernizes properties demo output formatting (interpolation). |
| snippets/csharp/System/TimeSpan/CompareTo/cto_eq_obj.cs | Modernizes CompareTo(Object) demo formatting/output. |
| snippets/csharp/System/TimeSpan/CompareTo/comp_equal.cs | Modernizes Compare/Equals demo formatting/output. |
| snippets/csharp/System/TimeSpan/Compare/compare1.cs | Modernizes Compare demo formatting/output. |
| snippets/csharp/System/TimeSpan/Add/add1.cs | Modernizes Add demo formatting/output. |
| snippets/csharp/System/TimeSpan/.ctor/ctorl.cs | Modernizes ctor(long ticks) demo formatting/output. |
| snippets/csharp/System/TimeSpan/.ctor/ctoriiiii.cs | Modernizes ctor(int,int,int,int,int) demo formatting/output. |
| snippets/csharp/System/TimeSpan/.ctor/ctoriiii.cs | Modernizes ctor(int,int,int,int) demo formatting/output. |
| snippets/csharp/System/TimeSpan/.ctor/ctoriii.cs | Modernizes ctor(int,int,int) demo formatting/output. |
| snippets/csharp/System/TimeoutException/Overview/to.cs | Modernizes TimeoutException sample formatting/indentation. |
| snippets/csharp/System/ThreadStaticAttribute/Overview/threadsafe2a.cs | Modernizes ThreadStatic sample (expression-bodied helpers). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…api-docs into modernize-code-system-t
gewarren
marked this pull request as ready for review
August 12, 2026 23:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #12713.
Internal previews
Toggle expand/collapse
Note
This table shows the first 30 preview links (sorted alphabetically by file path) found in the OPS build report. For the full list, select OpenPublishing.Build Details within checks.