Repository navigation
fix: guard all legacy listeners before pool adoption - #270
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pool adoption previously checked only127.0.0.1, missing a legacy controller listening on IPv6 or another local interface. Use bounded Linux ss socket inventory across every address family/interface, and refuse unavailable or ambiguous evidence. Validate the durable maintenance journal before any configured Docker pool can provision, so failed startup cannot leave new pools running. Document the native Linux host-network-namespace requirement.
Independent source review passed. Exact executable55c340c passed typecheck and focused real Beelink2 proof: an actual ::1-only listener blocks adoption and releases the unused ownership lock; closing it permits real adoption; malformed journal startup with a configured Docker backend creates zero containers. Gate beelink2-7e352c38ef5603efe6d580883b0f6ce5 passed30s (8s command). Final4e224ec adds documentation only. The unchanged189s real Docker/authenticated HTTP rolling proof from269 is reused. No model calls, dependencies or lockfile changes; fixture-owned container/volumes cleaned.
Fixes the two applicable postmerge269 review findings. The existing native Linux service deployer and authenticated per-slot API remain the production path.
Run ID: run_4b1d54cfdf2c05412b39044bf98511e1