Repository navigation
Avoid fetching all projects in the UI - #4449
Merged
Merged
Conversation
The field is unused since the edit payment method button was commented out. Remove the type field and the dead commented-out code.
The tutorial panel, GitHub login callback, Run launch project picker, and the no-fleet alerts on Runs and Fleets lists requested every visible project (all projects for admins, plus all public ones for members). Request only the current user's projects, with limit 1 for existence checks, and use list_only_no_fleets directly for the alerts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The UI requested up to 2000 visible projects, all projects for global admins, in places that need one project or none.
projects/list {username, limit: 1}, so public projects the user hasn't joined no longer count as theirs.?project_name=still preselects any project.projects/list_only_no_fleetsalone instead of also listing all projects.is_payment_method_attachedbilling info field and the commented-out "Edit payment method" code.runs/getand a FIXME about run costs being underestimated withjob_submissions_limit([Bug]: Run cost is underestimated in the run list for runs with multiple job submissions #4448).