Skip to content

Bugfix 461 get derived points - #477

Merged
bikegeek merged 2 commits into
developfrom
bugfix_461_get_derived_points
Aug 10, 2026
Merged

Bugfix 461 get derived points#477
bikegeek merged 2 commits into
developfrom
bugfix_461_get_derived_points

Conversation

@bikegeek

@bikegeek bikegeek commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

Pull Request Testing

  • Describe testing already performed for these changes:

    added a test to verify that the fix now generates results

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    verify that tests are passing

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [NA]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Do these changes introduce new SonarQube findings? [Maybe]

    If yes, please describe:
    code coverage is below threshold, resulting in possible quality gate failure

  • Please complete this pull request review by For RC1 release.

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or METcalcpy-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

…al R script code and use extend to flatten the result ( a list of tuples) to improve performance
@bikegeek bikegeek added this to the METcalcpy-13.0.0 milestone Aug 7, 2026
@github-project-automation github-project-automation Bot moved this to 🩺 Needs Triage in METplus-13.0 Development Aug 7, 2026
@bikegeek bikegeek moved this from 🩺 Needs Triage to 🛑 Not Ready in METplus-13.0 Development Aug 8, 2026
@bikegeek
bikegeek marked this pull request as draft August 8, 2026 14:51
@bikegeek bikegeek moved this from 🛑 Not Ready to 🟢 Ready in METplus-13.0 Development Aug 10, 2026
@bikegeek
bikegeek marked this pull request as ready for review August 10, 2026 16:02

@mollybsmith-noaa mollybsmith-noaa left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bikegeek
bikegeek merged commit c27f01a into develop Aug 10, 2026
9 of 12 checks passed
@github-project-automation github-project-automation Bot moved this from 🟢 Ready to 🏁 Done in METplus-13.0 Development Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🏁 Done

Development

Successfully merging this pull request may close these issues.

2 participants