Issue 339 error handling test coverage

[bikegeek]

Pull Request Testing

• Describe testing already performed for these changes:
  
  run all METdbLoad, METreformat, and METreadnc tests

• Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
  
  verify all tests pass, SonarQube gateway check may not reach threshold value

• Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [NA]

• Do these changes include sufficient testing updates? [Yes]

• Will this PR result in changes to the test suite? [Yes]
  
  If yes, describe the new output and/or changes to the existing output:
  
  Increased total coverage from 835 to 86%, additional test data and corresponding changes to test fixture code

• Do these changes introduce new SonarQube findings? [Yes]
  
  If yes, please describe:
  possible failure for gateway quality criteria

• Please complete this pull request review by [for RC1 release].
  

Pull Request Checklist

See the METplus Workflow for details.

• Add any new Python packages to the METplus Components Python Requirements table.
• Review the source issue metadata (required labels, projects, and milestone).
• Complete the PR definition above.
• Ensure the PR title matches the feature or bugfix branch name.
• Define the PR metadata, as permissions allow.
  Select: Reviewer(s) and Development issue
  Select: Milestone as the version that will include these changes
  Select: Coordinated METplus-X.Y Support project for bugfix releases or METdataio-X.Y.Z Development project for official releases
• After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
• After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
• Close the linked issue and delete your feature or bugfix branch from GitHub.

[mollybsmith-noaa]

This looks good, and I just have a couple of comments. SonarQube did fail, but looking at the log it threw a 503 error, and not something to do with your code. Was this expected?

[mollybsmith-noaa]

If you are satisfied with the behavior of SonarQube here, this is good to be merged.

[bikegeek]

I emailed Howard to see if there is something that changed in the sonarqube configuration. I expect to see the quality gate failure message because the test coverage is below the threshold value. I won't squash and merge until the sonarqube portion of the GHA is working again, just in case.