Update develop-ref after #3164 - #3196
Merged
Merged
Conversation
…st data directory prior to creating the main_vX.Y-ref branch.
* updating template first pass * removing backslash * removing extra # symbol * removing spaces. Keep as is * removing spaces for consistency * adding changes to match template * fixing spacing * fixing spacing take 2 * Per #2741, correcting typo in OUPUT_BASE in template file * Per #2741, correcting typo in OUPUT_BASE * Per #2741, updating sections based on template and template description * Updated language in several sections, needs additional work on output and config file * updating for consistency * Updating file based on suggestions from George * Updating with suggestions from George * Updating file based on suggestions from George * reviewing with Julie * Per #2741 attempting to resolve errors * Per #2741, updating template to fix rendering problems * Per #2741, fixing formatting * Per #2741 attempting to resolve warnings * Per #2741, resolving error * Resolving formatting problems with template * Fixing formatting problems * updating for consistency * fixing formatting * removing extra spaces * Updating formatting * updating for consistency * adding METplus Workflow times * modifications * Update GridStat_fcstCESM_obsGFS_ConusTemp.py Added some information to the use case * Update MODE_fcstCESM_obsGPCP_AsianMonsoonPrecip.py Updates * Added an extra blank line * updating for consistency * fixing spacing * adding space * removing Update content * updating for consistency * adding a period * updating for consistency * updating for consistency * updating for consistency * updating for consistency * adding return * replacing underlines * replacing return? * fixing blank line * more attempts to fix warnings * updating for consistency * adding double colons and stuff * trying stuff * trying extra spacing * Changing Datasets Location info to match template * Per #2741, updating formatting and wording * Per #2741, updating after reviewing * Per #2741, attempting to resolve errors * updating for consistency * fixing brackets and section breaks * adding return * Per #2741, updating after reviewing * updating for consistency * fixing spacing * adding a pound * Updating wording for User Scripting * Updating the text for User Scripting * Updating User Script section * Updating text for User Scripting * Updating text * adding location information * adding location information * updated first cloud file, will use for remaining cloud use cases * updated language in numerous use case doc files * updated final marine use case --------- Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> Co-authored-by: j-opatz <59586397+j-opatz@users.noreply.github.com> Co-authored-by: Christina Kalb <kalb@ucar.edu> Co-authored-by: j-opatz <jopatz@ucar.edu>
* marine_and_cryosphere directories * fixing underlining * trying to fix warning msg. * trying to fix warning msg. again * Removing space before i.e. * updating medium_range and pbl directories * deleting empty file * removing lots of old text * precipitation files * removing junk file * removing extra # * add return * updating 3 dirs s2s, space_weather and unstructured_grids * updating short_range files * adding tc_and_extra_tc files * removing defunct -c option * Updating Datasets section * Added needed return character before "#Pass" * Added /path/to/user_system.conf to end of run_metplus.py line * Added a comma after "command line" * Updating file path * Added fields for empty Satasets section --------- Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>
* update existing builds for upcoming coordinated 6.1 (beta1) release * added template for existing builds for next dev cycle and added it to ignore list * Update release guide instructions to set the new location of the Existing Builds page on the Downloads page. Update instructions for creating a new existing builds page to instead copy the template and replace values in the develop branch * added a step to update the development timeline info for an official release * Updating existing_builds files * changed Docker Hub to DockerHub * added step to update the DockerHub info on the Existing Builds page * change version to official release because RAL-IT doesn't install development releases on RAL machines --------- Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>
* marine_and_cryosphere directories * fixing underlining * trying to fix warning msg. * trying to fix warning msg. again * Removing space before i.e. * updating medium_range and pbl directories * deleting empty file * removing lots of old text * precipitation files * removing junk file * removing extra # * add return * updating 3 dirs s2s, space_weather and unstructured_grids * updating short_range files * adding tc_and_extra_tc files * removing defunct -c option * added dropdown menus for marine_and_cryosphere * fixing problems and dropdowns for medium_range * fixing new problems * dropdowns for pbl and precip * adding double colons * Attempting to resolve errors * dropdowns for s2s and s2s_mjo * adding dropdowns for short_range files * final dropdown directories * Update docs/use_cases/model_applications/marine_and_cryosphere/GridStat_fcstRTOFS_obsGHRSST_climWOA_sst.py removing note Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Apply suggestions from code review adding all of the suggestions Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Update GridStat_fcstRTOFS_obsGHRSST_climWOA_sst.py ensuring literal include is in dropdown menu * Update GridStat_fcstRTOFS_obsOSTIA_iceCover.py ensuring literal include is in dropdown * ensuring literal include is in dropdown menu * marine_and_cryosphere MET Configuration dropdown fixes * remaining dropdown directories for MET Configuration * Julie changing dropdowns Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * HEAD needed to be removed * There are not MET tools used in this use case * There are no MET tools used in this use case * Apply suggestions from code review Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Per #2741, few small changes * updates from pull request discussion * removing space Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * fixing dropdown Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * removing bash Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * update from Julie Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Fixing error * lots of typos Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> * Adding period * Adding colon * Added period * Added period * Added period * typos and more Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> --------- Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>
* exclude metplus/scripts dir from PyCharm project to prevent incorrect duplicate code warnings with files that are sym linked * to expand on #2772, updating instructions to include note to set tmp directory for apptainer to prevent issues pulling large images that require a lot of temp space * per #511, add unit test for expected behavior to support comma-separated lists in a command line single config override that should fail until fix is made * add a test to ensure that the -c argument is properly ignored since it is can be used in old use cases that were created when the argument was required * per #511, add support for command line single config overrides to include values that are lists. Simplify logic to parse arguments to strip out -c/--config/-config arguments and skip check/error if argument is invalid because it is already handled in the metplus_config setup step that parses the arguments * added unit test to ensure that an invalid command line argument causes the appropriate failure from run_metplus.py
* adding In Memoriam section * Changing to "This Coordinated Release is dedicated to" removing version * adding links * fixing Randy's link * Per #2780, change case of words and add comma after year --------- Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>
* per #2816, update title of workflow displayed in Actions tab to display the repo that triggered the workflow on workflow_dispatch events. Preserve the behavior of pull_request and push events by displaying the PR title or head commit message respectively * fix logic for run-name * Update event info to note that the workflow was triggered manually if the repo/title was not provided. Update description of workflow_dispatch argument to describe what it can be used for when triggering manually. Only run step to build URL to commit that triggered workflow if it was triggered from an external repo * add optional argument for workflow_dispatch to specify the title of the workflow run * revert change to repository argument description since title argument was added to handle custom workflow run titles
* per #2814, add documentation to describe how to set a single config variable on the command line * fixed typos and formatting issues * move new content to top of chapter and reword intro sentence * change label and add link to user env var section * per #2814, added info and examples for single config overrides with a list of values
… dev release notes. improve naming of drop downs for generating dev release notes to be consistent
* Per #3100, if var/field information differs for files gathered for the same run but with different time information (like running ONCE_PER_INIT_OR_VALID), then instead of failing an assert, replace the differing var item with a wildcard. This can occur when time information is specified in the field level, because each time will contain a different level value. The values stored in the var_list for all files appears to only be used to set output information like output_prefix, so it is more accurate to store a wildcard here so it is clear that there is not a single level value used to gather these data. * Per #3100, add unit test to recreate assertion failure * fix link to info about how to obtain Gempak utility * fix logic to handle differing var/field info * Per #3100, add unit test for case where time info is used in data field * Per #3100, move logic in SeriesAnalysis wrapper so it can be used by GridDiag and potentially other wrappers. This logic handles formatting field info to properly substitute time information for each input. Also set input_time_info for each input data read so that this information can be read elsewhere as needed -- this info differs from the time_info that is already stored because that value is specific to the output time and can contain a wildcard character to note multiple times, e.g. multiple leads or init times
* Per #3157, update glossary entry for RegridDataPlane verification grid to note that the value can be a named grid or a grid specification string, not just a path to a file * Per #3157, add unit tests to demonstrate failure wrt verification grid values that already include quotation marks. * Per #3157, add call to remove_quotes to properly handle when user puts quotes around the input value * remove unused import
Remove unnecessary index.html files after data download.
* Per #3169, add tests to demonstrate bug described in the issue * clean up unit tests to reduce duplication * Per #3169, add properly handle quotes around field name * Per #3169, add more tests that expose another situation that does not properly handle quotes that should be addressed * Per #3169, properly handle quotes for field name when input is GRIB PDS * add a test that exposes a crash when GRIB PDS is configured but no thresholds are provided * Raise ValueError exception if misconfiguration where no thresholds are specified for PROB data in GRIB PDS instead of crashing with cryptic error message. Enhance test to check for the exception
* update commit of coveralls GHA to fix permission failure * fix typo in commit hash * rearrange badges and add conda and coverage badges * Per #3171, add information about conda install * change dateutil requirement to >= version because exact version is not actually required * add link and clean up wording * Per PR feedback from @jprestop, add information about creating a conda environemnt (if desired) and activating an environment before installing METplus. Also add supported platform and version information * rename example conda env name as requested by @jprestop
* clean up tests to use common functionality to test wrapper runs and add expected command to compare * Per #2983, add tests to demonstrate bug * Per #2983, modified existing tests to ensure that _beg and _end values are computed properly when time values are listed out of order, while preserving the order that the items were specified by the user * Per #2983, add sort_list=False to calls to get_met_time_list when the order of the items specified by the user should be preserved. Also added sort_list=True, which is the default value, to all calls to get_met_time_list and get_delta_list so it is more clear that the lists returned by those calls are sorted * Add test to demonstrate bug with multiple grouped models as described in discussion #2982, fix bug by removing whitespace around model values that are formatted with quotation marks and a space after each comma * Add support for setting column, weight, ss_index_name, and ss_index_vld_thresh in MET config file -- these were set using config overrides in discussion #2982. Also added missing test for hss_ec_value * cleanup to reduce cognitive complexity and resolve linter complaints * added and modified tests to increase code coverage * change return value of function to prevent crash when wrapper is misconfigured -- a new unit test to ensure that the wrapper reports an error uncovered that it crashes instead of gracefully reporting the misconfiguration * cleanup formatting and update incorrect comments * add tests to increase code coverage and ensure correct results for other configurations
* Update diff_util.py to flag differences in NetCDF files based on the number of grid points with masked bad data values. * Update make_nc logic to define the fill_value attribute for the temp variable and add a test to confirm differing number of valid data.
* remove unused variable * resolve 'Bad use of null-like value' issue * resolve 'Copy-paste error' OTTI issue and make script more efficient by reducing the number of file reads * remove function that is not used by the use cases * remove unused functions, reduce duplicate code, and reduce cognitive complexity * refactor to reduce cognitive complexity and implement better error checking to prevent null access * return z500 detrend value passed to function if EOF not computed instead of None, updated comment * use env var to easily change conda location in commands to match your local location * Fixing output directories * Per #3146, SQ: refactor to reduce cognitive complexity --------- Co-authored-by: Christina Kalb <kalb@ucar.edu>
* Adding use case image * Adding MvMODE FireWx use case * Adding Fire Weather use cases * Updating use case image * Adding new use cases to the use case groups * Updating python embedding file * Updating documentation * Updating documentation and MTD use case * Adding HRRR use case * Adding documentation for Point-Stat use case * Updating use case groups, etc * Fixing some bad documentation links * Changing m/s to mph * Fixing weird link * Fixing file names * Adding some use case updates * Updating MvMODE case to use multiple thresholds * Updating images * Adding plotting yaml files * Fixing missing semicolon * Updating documentation * Fixing indent * Turning on one of the tests * MTD use case testing * Testing PointStat use case * Testing MvMODE use case * Removing CI override because it's behaving oddly * Updating MvMODE case to run all steps * Reducing automated testing for fire2 * Adding py_embed to use case group * Documentation corrections and updates * Fixing list error * Another documentation update * Documentation updates * Shortening testing for Point-Stat case * Changes * Updating contributors guide * Updating contributors guide * Updates * Updating a path to be more consistent * removing commented out line * Turning tests off for PR * SonarQube Sucks * Updating path * Fixed incorrect threshold * updated language, spelling --------- Co-authored-by: Christina Kalb <kalb@seneca.rap.ucar.edu> Co-authored-by: j-opatz <jopatz@ucar.edu>
github-project-automation
Bot
moved this from 🩺 Needs Triage
to 🏁 Done
in METplus-13.0 Development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding truth data for 3 new fire use cases, updating medium range use cases due to inconsistent location
Created by @CPKalb