Feature #2570 file_type

[georgemccabe]

Pull Request Testing

• Describe testing already performed for these changes:
  

• Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
  

• Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]

• Do these changes include sufficient testing updates? [Yes or No]

• Will this PR result in changes to the test suite? [Yes or No]
  
  If yes, describe the new output and/or changes to the existing output:
  

• Do these changes introduce new SonarQube findings? [Yes or No]
  
  If yes, please describe:

• Please complete this pull request review by [Fill in date].
  

Pull Request Checklist

See the METplus Workflow for details.

• Add any new Python packages to the METplus Components Python Requirements table.
• For any new datasets, an entry to the METplus Verification Datasets Guide.
• Review the source issue metadata (required labels, projects, and milestone).
• Complete the PR definition above.
• Ensure the PR title matches the feature or bugfix branch name.
• Define the PR metadata, as permissions allow.
  Select: Reviewer(s) and Development issue
  Select: Milestone as the version that will include these changes
  Select: Coordinated METplus-X.Y Support project for bugfix releases or METplus-Wrappers-X.Y.Z Development project for official releases
• After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
• After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
• Close the linked issue and delete your feature or bugfix branch from GitHub.

[coveralls]

Pull Request Test Coverage Report for Build 21639887700

Details

• 23 of 24 (95.83%) changed or added relevant lines in 13 files are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage decreased (-0.004%) to 92.497%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
metplus/wrappers/command_builder.py	8	9	88.89%

Files with Coverage Reduction	New Missed Lines	%
metplus/wrappers/grid_diag_wrapper.py	1	96.1%

Totals
Change from base Build 21639814746:	-0.004%
Covered Lines:	9517
Relevant Lines:	10289

---

💛 - Coveralls

[JohnHalleyGotway]

I see that this PR adds support for setting the FILE_TYPE to the configuration of multiple tools. And I also see that all the GHA tests have passed.

But checking the details in glossary.rst, I have some questions. Can you please take a look?

1. GRID_STAT_OBS_FILE_TYPE is added but OBS_GRID_STAT_FILE_TYPE already exists.
2. In MOST wrappers, the file type options are named {MET-TOOL}_{FCST|OBS}_FILE_TYPE, but the Grid-Stat and Wavelet-Stat wrappers are named {FCST|OBS}_{MET-TOOL}_FILE_TYPE.

> egrep '_FILE_TYPE' glossary.rst  | egrep ' FCST_| OBS_'
   FCST_GRID_STAT_FILE_TYPE
   OBS_GRID_STAT_FILE_TYPE
   FCST_WAVELET_STAT_FILE_TYPE
   OBS_WAVELET_STAT_FILE_TYPE

Can we make these consistent throughout?
I think we need to deprecate FCST/OBS_GRID_STAT_FILE_TYPE and FCST/OBS_WAVELET_STAT_FILE_TYPE and add GRID_STAT_FCST_FILE_TYPE and WAVELET_STAT_FCST/OBS_FILE_TYPE.
3. I think you added support for GRID_DIAG_FILE_TYPE, but it's missing from glossary.rst.

[JohnHalleyGotway]

I approve. Thanks for making these changes.