Updated Netty and stabilized ChunkedInputClosedOnErrorTest - #6109
Merged
Conversation
- The test randomly failed and it still does, however now it checks the exception, runs more iterations (100 or more instead of 10), and is more readable. Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
- flush doesn't guarantee the end of input, however it should be close. Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Member
|
Basically +1 if not Jenkins would fail :-( |
Contributor
Author
That is the other flaky test on my radar, tls ... restarted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Netty changelog:
ChunkedInputClosedOnErrorTest Changes