Skip to content

Enhanced License Check - #6112

Merged
dmatej merged 1 commit into
4.xfrom
licenses
Jul 25, 2026
Merged

Enhanced License Check#6112
dmatej merged 1 commit into
4.xfrom
licenses

Conversation

@dmatej

@dmatej dmatej commented Jul 25, 2026

Copy link
Copy Markdown
Contributor
  • As we are getting blacklisted from data websites, we have to limit the usage
  • Now the check can be executed manually using /check-license comment
  • It will be still manually executed daily on main branch
  • It can be executed also from the Actions menu
  • Removed staging profile
  • Switched to Temurin JDK
  • Related GitLab issue: https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/work_items/7694

Validation of this PR

  • First I pushed the updated action file to the branch 4.x in my own repository and I set it as the main branch.
  • Then I created another branch with any trivial change, and PR to 4.x
  • Then I commented the PR with /check-license (/license-check works too)

The check passed, and the PR automatically received this comment: dmatej#126 (comment)

Then I closed the PR. Failure should not block merge of the PR.

Notes

  • The comment will not work until we merge this PR, that is why I had to use my own repo for testing.
  • The summary in the comment is trimmed by GitHub, the original file can be downloaded from the action run.

@dmatej

dmatej commented Jul 25, 2026

Copy link
Copy Markdown
Contributor Author

/check-license

@dmatej
dmatej marked this pull request as ready for review July 25, 2026 13:07
@pzygielo

This comment was marked as outdated.

@dmatej

dmatej commented Jul 25, 2026

Copy link
Copy Markdown
Contributor Author

@pzygielo I started doing experiments on my repository, so don't burn your time with this one yet.

@dmatej
dmatej marked this pull request as draft July 25, 2026 14:26
- As we are getting blacklisted from data websites, we have to limit the usage
- Now the check can be executed manually using /check-license comment
- It will be still manually executed daily on main branch
- It can be executed also from the Actions menu
- Removed staging profile
- Switched to Temurin JDK

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
@dmatej

dmatej commented Jul 25, 2026

Copy link
Copy Markdown
Contributor Author

/check-license

@dmatej dmatej added this to the 2.49 milestone Jul 25, 2026
@dmatej
dmatej requested a review from a team July 25, 2026 15:19
@dmatej
dmatej marked this pull request as ready for review July 25, 2026 15:19
@dmatej

dmatej commented Jul 25, 2026

Copy link
Copy Markdown
Contributor Author

@pzygielo Now it is ready, just the new configuration will start working after the merge, so trying these comments now is worthless. But I have tested it in my own repo and added results to the PR description. I can also run the action manually against selected branch (in the same repository):
image

@pzygielo

Copy link
Copy Markdown

@dmatej - seems it was activated on my comment for https://github.com/dmatej/jersey/actions/runs/30164949485

so.... it will react on comment from anyone? 🤔

@dmatej

dmatej commented Jul 25, 2026

Copy link
Copy Markdown
Contributor Author

@dmatej - seems it was activated on my comment for https://github.com/dmatej/jersey/actions/runs/30164949485

so.... it will react on comment from anyone? 🤔

Great question, I will fix it!

@dmatej

dmatej commented Jul 25, 2026

Copy link
Copy Markdown
Contributor Author

@pzygielo Can you try that now?

@pzygielo

Copy link
Copy Markdown

Can you try that now?

Better - it was skipped.

👍

@dmatej dmatej modified the milestones: 2.49, 4.0.3 Jul 25, 2026
@dmatej
dmatej merged commit 56d6ce6 into 4.x Jul 25, 2026
8 checks passed
@dmatej
dmatej deleted the licenses branch July 25, 2026 17:07
@pzygielo

Copy link
Copy Markdown

I can't see anything similar to the code from fork:
contains(fromJSON('["OWNER","MEMBER","COLLABORATOR"]'), github.event.comment.author_association)
to be applied here.

@pzygielo

Copy link
Copy Markdown

I can't see anything similar to the code from fork: contains(fromJSON('["OWNER","MEMBER","COLLABORATOR"]'), github.event.comment.author_association) to be applied here.

@dmatej - see

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants