Remove blind settle delay from code mining test fixtures - #4213
Merged
vogella merged 1 commit intoJul 30, 2026
Merged
Conversation
Contributor
vogella
force-pushed
the
lv/codemining-drop-settle-sleep
branch
2 times, most recently
from
July 28, 2026 15:28
fef4baf to
95b8d19
Compare
vogella
marked this pull request as ready for review
July 28, 2026 15:28
vogella
force-pushed
the
lv/codemining-drop-settle-sleep
branch
from
July 29, 2026 08:00
95b8d19 to
4d58955
Compare
CodeMiningTest.setUp() and CodeMiningLineHeaderAnnotationTest.setUp() both ended with DisplayHelper.sleep(display, 1000), placed directly after a waitForCondition() that had already established that the text widget is visible. DisplayHelper.sleep() is waitForCondition() with the condition hardcoded to false, so it always burns the full second. CodeMiningTest installs its provider on an empty document, and the provider skips blank lines, so no code minings are produced during setUp and there is nothing to settle for. Measured on a full CI run, CodeMiningTest is 22.6s over 19 tests with a median of 1.04s against a minimum of 0.19s, and CodeMiningLineHeaderAnnotationTest is 4.0s over 4 tests with minimum and median both 1.01s.
vogella
force-pushed
the
lv/codemining-drop-settle-sleep
branch
from
July 30, 2026 11:18
4d58955 to
d099cba
Compare
Contributor
Author
|
Three test runs now, no flakyness so I merge this test runtime improvement. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CodeMiningTest.setUp()andCodeMiningLineHeaderAnnotationTest.setUp()both ended withDisplayHelper.sleep(display, 1000), placed directly after awaitForCondition()that had already established that the text widget is visible.DisplayHelper.sleep()iswaitForCondition()with the condition hardcoded tofalse, so it always burns the full second. InCodeMiningTestthe provider is installed on an empty document and skips blank lines, so no code minings are produced during setup and there is nothing to settle for.On a recent full CI run
CodeMiningTestwas 22.6s over 19 tests with a median of 1.04s against a minimum of 0.19s, andCodeMiningLineHeaderAnnotationTestwas 4.0s over 4 tests with minimum and median both 1.01s. Locally the passing tests drop from 22.6s to 5.8s, with each affected test falling by almost exactly the removed second.