Remove the unreachable reflection-based property handler dispatch - #4215
Merged
vogella merged 1 commit intoJul 30, 2026
Merged
Conversation
Contributor
Test Results 858 files - 3 858 suites - 3 53m 3s ⏱️ + 2m 53s Results for commit 2bd3d96. ± Comparison against base commit 036c95f. This pull request removes 1 test.♻️ This comment has been updated with latest results. |
Production registers exactly one property handler provider: CSSSWTEngineImpl adds RegistryCSSPropertyHandlerProvider, which is driven by the propertyHandler extension point. The two alternative providers resolved handlers by reflecting over a naming convention (background-color to CSSPropertyBackgroundColorHandler) and were reachable only through CSSEngineImpl.registerPackage, registerCSSProperty and registerCSSPropertyHandler. Nothing in the platform calls those three methods, so the whole path was dead. Delete both providers, the exception only they threw, the three registration methods with their lazy init helpers, and the test that pinned the naming convention. The similarly named registerCSSPropertyHandlerProvider stays: it is the live provider-level registration used by CSSSWTEngineImpl. This removes the last naming-convention reflection from the engine.
vogella
force-pushed
the
css-drop-reflection-dispatch
branch
from
July 30, 2026 11:18
0c61744 to
2bd3d96
Compare
vogella
marked this pull request as ready for review
July 30, 2026 11:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CSS engine could resolve property handlers two ways: through the
propertyHandlerextension point, and by reflecting over a naming convention that mappedbackground-colorto aCSSPropertyBackgroundColorHandlerclass. Only the first is actually used.CSSSWTEngineImplregistersRegistryCSSPropertyHandlerProviderand nothing else, and the reflective providers were reachable only throughCSSEngineImpl.registerPackage,registerCSSPropertyandregisterCSSPropertyHandler, which nothing in the platform calls.This deletes both providers, the exception only they threw, those three registration methods with their lazy-init helpers, and the test that pinned the naming convention. The similarly named
registerCSSPropertyHandlerProvideris untouched, since that is the live provider-level registration point thatCSSSWTEngineImpland third-party engines use.Net 601 lines removed, and the last naming-convention reflection is gone from the engine, which makes handler resolution something you can read rather than guess at. All affected types are
x-internal. Both CSS suites are green locally, 131 in css.core and 210 in css.swt.