Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused fix preserves successful comparison behavior and includes regression coverage, with no unresolved findings.
No open issues 🎉
What changed in this PR
This PR prevents lazy GitHub comparison failures from interrupting repository metric collection when refs have unrelated histories.
Changes:
- Guard lazy divergence-count reads with the existing exception handling.
- Log a repository-specific warning when refs have no common ancestor.
- Add tests for successful comparisons, immediate failures, and lazy no-common-ancestor errors.
| File | Description |
|---|---|
| tests/test_repo_overview.py | Adds focused comparison and error-handling regression coverage. |
| src/generate_repo_overview/collector/reference_integration.py | Catches lazy comparison failures and warns when histories are unrelated. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.