fix(paste): use textContent instead of innerHTML to avoid HTML tags in code - #80
Open
waterWang wants to merge 1 commit into
Open
fix(paste): use textContent instead of innerHTML to avoid HTML tags in code#80waterWang wants to merge 1 commit into
waterWang wants to merge 1 commit into
Conversation
…n code When pasting a <pre> element containing <code> child tags, element.innerHTML returns the HTML including the <code> tag. Using textContent extracts only the plain text, which is the correct behavior for code blocks. Ref: codex-team/editor.js#3010
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes pasting code blocks rendering as
[object HTMLPreElement].When pasting a
<pre>element that contains child<code>tags (as browsers produce when copying code from pages/IDEs),element.innerHTMLreturns the HTML including the<code>tag, which leaks markup into the code field.element.textContentextracts only the plain text — the correct content for a code block.Root cause reference
[object HTMLPreElement]instead of code content)Test Plan
<pre><code>...</code></pre>block now yields plain code text without HTML tags<pre>content