Repository navigation
fix(vue): keep live-query writes flowing after an interrupted discovery - #932
Merged
Merged
Conversation
…fore ready Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@effect-app/cli
effect-app
@effect-app/eslint-codegen-model
@effect-app/eslint-shared-config
@effect-app/infra
@effect-app/vue
@effect-app/vue-components
commit: |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Follow-up to #930, found during its Sol review.
beginLiveQueryFetchincrementeddiscoveringbefore awaitingsource.ready(), but the caller only recorded the result after the await. If a live fetch was interrupted during that await (unmount, superseding refresh), the finalizer ran withfalseand never decremented. From then on, every repository write was buffered and never dispatched, so all live queries went stale.What
liveQueryInvalidation.ts: add a synchronousacquireLiveQueryFetchplusliveQueryReady.beginLiveQueryFetchstays as a deprecated export (it is reachable through the./*subpath export).atomQuery.ts: wrap the live fetch inEffect.acquireUseRelease, soendLiveQueryFetchalways gets the acquired token, including after an interrupt or aready()failure.main, passes here.@effect-app/vue.opened by andreasimonecosta in chat thread Discord · Discord · T3
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.