Repository navigation
test: cover HlsSegmenter's live mode combined with MpegTs format - #119
Merged
Merged
Conversation
Category 0 review of the streaming work merged today: every prior test exercised live mode and MpegTs format independently, but never together, even though both are real, independent constructor options a caller can combine. Verified the combination already works correctly (no bug found) and added a regression test closing the gap: confirms the live window is still enforced, no init segment/EXT-X-MAP is written, segment URIs use the .ts extension, and every retained segment is still a well-formed TS file. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SegmentFormat.MpegTsindependently, but never together, even though both are real, independently-selectable constructor options a caller can combine.Test plan
LiveMode_Combined_With_MpegTsFormat_Should_PruneSegments_AndOmitExtXMap: confirms the live window is still enforced under the MpegTs format (only the most recent N segments retained, correct keys), no init segment/EXT-X-MAPis written, segment URIs use the.tsextension, and every retained segment is still a well-formed TS file (starts with the sync byte).dotnet test, net10.0 locally): 1687 passed, 1 pre-existing unrelated skip, 0 failed.🤖 Generated with Claude Code