Repository navigation
Conversation
Skip the UpdateClusterConfig call when the cluster's authentication mode
already matches the desired mode: the EKS API rejects no-op updates with
InvalidParameterException ("Unsupported authentication mode update from
X to X"), which broke idempotent re-runs from CI/GitOps pipelines. The
cluster description is already cached on the cluster provider, so no
extra API call is needed.
Also log the authentication mode resolved from the cluster config
instead of the --authentication-mode flag, which is empty when the mode
comes from a config file via -f.
Signed-off-by: Steffen Windoffer <steffen.windoffer@exaring.de>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #8903
eksctl utils update-authentication-modecalledUpdateClusterConfigunconditionally. The EKS API rejects an update where the target authentication mode equals the current one withInvalidParameterException: Unsupported authentication mode update from API_AND_CONFIG_MAP to API_AND_CONFIG_MAP, so any idempotent re-run (CI pipelines, GitOps) failed hard.Changes:
NewProviderForExistingCluster/RefreshClusterStatus, so no extraDescribeClustercall is needed.setting cluster's authentication mode to %slog line to print the mode resolved from the cluster config instead of the--authentication-modeflag, which is empty when the mode comes from a config file via-f.doUpdateAuthenticationModeinto a helper taking the cluster provider so it can be unit-tested with the mock provider.Checklist
README.md, or theuserdocsdirectory)area/nodegroup) and kind (e.g.kind/improvement)