Skip to content

ci: let Dependabot label all its pull requests - #493

Merged
uniqueg merged 2 commits into
devfrom
ci/492-dependabot-labels
Nov 14, 2026
Merged

uniqueg merged 2 commits into
devfrom
ci/492-dependabot-labels

Conversation

@uniqueg

@uniqueg uniqueg commented Nov 14, 2026 •

Copy link
Copy Markdown
Member

Summary

Lets Dependabot label all its pull requests, security updates included, with the organisation's label type: dependencies only, instead of its own labels (dependencies plus an ecosystem label).

In .github/dependabot.yml:

  • Remove target-branch: dev from the 4 entries that set it (uv, github-actions, docker, pre-commit) and from the multi-ecosystem group service-images. dev is the default branch, so version updates still target it.
  • Replace the header comment about target-branch with one that explains why no entry sets it.
  • Keep the ignore rules. They now also apply to security updates: the connexion major hold, the MongoDB 7.0 hold, foca-common (bumped by hand), and foca and elixircloud/foca, which are bumped by hand together with the base image (a lone bump breaks the image build), so Dependabot won't open security updates for FOCA either. That's intended.

Nothing else changes: compared as data (keys sorted), the new file equals the old one minus target-branch plus labels on every entry.

Closes #492

Light lane: CI configuration only (Dependabot), no secrets, permissions or release workflow touched, so the reviewer subagents were skipped; I reviewed the diff myself.

Verification

  • yq parses the new .github/dependabot.yml; every updates entry has labels: ["type: dependencies"]; no target-branch is left.
  • Semantic diff against the default branch (yq -o=json 'sort_keys(..)'): only the intended change.
  • CI: all checks pass (CI passed green) after merging dev, which brought the dnspython fix of build(deps): bump dnspython from 2.9.1 to 2.9.2 #491 (CVE-2026-128089 had failed Scan image before).

Declined review findings

None.

Open questions

None.

🤖 Generated with Claude Code

Summary by Sourcery

Enhancements:

  • Configure Dependabot to apply the type: dependencies label consistently to all pull requests, including security updates, by relying on the default branch rather than explicit target branches.

Remove `target-branch` from every Dependabot entry: it names the default
branch anyway, and while it is set, GitHub doesn't apply an entry's
options, labels included, to security updates. Security update pull
requests then get `type: dependencies` instead of Dependabot's own
labels. The `ignore` rules now also apply to security updates, as
intended.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@uniqueg uniqueg self-assigned this Nov 14, 2026
@sourcery-ai

sourcery-ai Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

Reviewer's Guide

Configuration

Remove target-branch: dev from all Dependabot entries and the service-images group so their configured labels and ignore rules also apply to security updates, and update the explanatory comment.

  • .github/dependabot.yml L2-113 (6 small edits)

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@codecov

codecov Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (96c326f) to head (eea5568).

Additional details and impacted files
@@            Coverage Diff            @@
##               dev      #493   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           35        35           
  Lines         3239      3239           
=========================================
  Hits          3239      3239           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@uniqueg
uniqueg marked this pull request as ready for review November 14, 2026 20:36
@sourcery-ai

sourcery-ai Bot commented Nov 14, 2026

Copy link
Copy Markdown

Linked issues

Checked at commit eea5568

#492 ci: let Dependabot label all its pull requests · 5 of 6 met · 1 to check by hand

# Requirement Status Notes
1 Remove target-branch from every entry and group. ✅ Met The service-images group and all four entries no longer set target-branch.
2 Update the header comment explaining target-branch. ✅ Met The new comment explains that the default branch is dev and that setting target-branch prevents options from applying to security updates.
3 Keep the ignore rules. ✅ Met The existing ignore rules remain in the uv, docker, docker-compose, and helm entries.
4 Every updates entry sets labels: ["type: dependencies"]. ✅ Met All six update entries have the requested label.
5 Make no other file changes beyond the requested target-branch removals and comment update. ✅ Met The diff contains only those removals and the header comment change.
6 Dependabot pull requests, including security updates, carry only type: dependencies. 👀 Check by hand (external system) Check a Dependabot pull request opened after this change, including a security update if one occurs, to confirm it carries only the type: dependencies label.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Needs a human reviewer. With target-branch removed, Dependabot’s existing ignore rules can now suppress matching security-update PRs, leaving affected dependencies without an offered fix. Reverting restores the prior behavior, but any time spent running with an update suppressed cannot be undone.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@uniqueg
uniqueg merged commit f17294e into dev Nov 14, 2026
68 checks passed
@uniqueg
uniqueg deleted the ci/492-dependabot-labels branch November 14, 2026 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: let Dependabot label all its pull requests

1 participant