fix: correct typos in source, tests, and docs - #1101
Open
TheGreatApollyon wants to merge 1 commit into
Open
Conversation
- seperately → separately (connection_pool.py) - dependancy → dependency (docs/proxies.md) - intial → initial (test files) - wit → with (test comments)
There was a problem hiding this comment.
Pull request overview
This PR corrects spelling/grammar typos across httpcore’s connection pool internals, proxy documentation, and both sync/async test suites to improve readability and reduce documentation/test noise.
Changes:
- Fixes
seperately→separatelyin sync/async connection pool docstrings. - Fixes
dependancy→dependencyin SOCKS proxy documentation. - Fixes
intial→initialandwit→within sync/async proxy/connection pool tests’ comments/docstrings.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/_sync/test_socks_proxy.py | Fixes comment/docstring typos in sync SOCKS proxy tests. |
| tests/_sync/test_http_proxy.py | Fixes comment typos in sync HTTP proxy tests. |
| tests/_sync/test_connection_pool.py | Fixes comment typos in sync connection pool tests. |
| tests/_async/test_socks_proxy.py | Fixes comment/docstring typos in async SOCKS proxy tests. |
| tests/_async/test_http_proxy.py | Fixes comment typos in async HTTP proxy tests. |
| tests/_async/test_connection_pool.py | Fixes comment typos in async connection pool tests. |
| httpcore/_sync/connection_pool.py | Fixes a docstring typo in sync connection pool request assignment logic. |
| httpcore/_async/connection_pool.py | Fixes a docstring typo in async connection pool request assignment logic. |
| docs/proxies.md | Fixes a typo in SOCKS dependency installation guidance. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes several typos across the codebase:
seperately→separatelyin connection_pool.pydependancy→dependencyin docs/proxies.mdintial→initialin test files (22 occurrences)wit→within test comments