Skip to content

Detect GCC $LC literals as strings #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LagoLunatic wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −0
Open

Detect GCC $LC literals as strings #398

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions objdiff-core/src/arch/ppc/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,6 +379,11 @@ impl Arch for ArchPpc {
return Some(ty);
}
}
if reloc.is_some_and(|r| r.symbol.name.starts_with("$LC")) {
// GCC compiler-generated symbol name for a literal.
// This could be a float literal instead of a string literal, so only check this after the opcode.
return Some(DataType::String);
}
if bytes.len() >= 2 && bytes.iter().position(|&c| c == b'\0') == Some(bytes.len() - 1) {
// It may be an unpooled string if the symbol contains exactly one null byte at the end of the symbol.
return Some(DataType::String);
Expand Down