Skip to content

Add tests for DictPropertyBag and type hints for IPropertyBag. - #860

Merged
junkmd merged 2 commits into
enthought:mainfrom
junkmd:dict_property_bag_test
Jul 12, 2025
Merged

Add tests for DictPropertyBag and type hints for IPropertyBag.#860
junkmd merged 2 commits into
enthought:mainfrom
junkmd:dict_property_bag_test

Conversation

@junkmd

@junkmd junkmd commented Jul 12, 2025

Copy link
Copy Markdown
Collaborator

This PR adds a new test class, Test_DictPropertyBag, to test the IPropertyBag interface's functionality via the DictPropertyBag implementation.
This includes tests for:

  • Reading existing properties.
  • Writing new properties.
  • Updating existing properties.
  • Handling attempts to read non-existent properties.

Additionally, this introduces type hints for the IPropertyBag interface methods (Read and Write) within a TYPE_CHECKING block.

junkmd added 2 commits July 12, 2025 10:26
- Introduce `TYPE_CHECKING` block for `Read` and `Write` methods in `IPropertyBag`.
@junkmd junkmd added this to the 1.4.12 milestone Jul 12, 2025
@junkmd junkmd added tests enhance or fix tests typing related to Python static typing system labels Jul 12, 2025
@codecov

codecov Bot commented Jul 12, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.52%. Comparing base (8dcee01) to head (8fb2a75).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #860      +/-   ##
==========================================
+ Coverage   83.35%   83.52%   +0.16%     
==========================================
  Files         123      123              
  Lines       11300    11325      +25     
==========================================
+ Hits         9419     9459      +40     
+ Misses       1881     1866      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@junkmd
junkmd marked this pull request as ready for review July 12, 2025 03:29
@junkmd
junkmd merged commit baa91ac into enthought:main Jul 12, 2025
144 of 150 checks passed
@junkmd
junkmd deleted the dict_property_bag_test branch July 12, 2025 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests enhance or fix tests typing related to Python static typing system

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant