chore: poc of state / memento pattern - #1547
Draft
tj098895 wants to merge 1 commit into
Draft
Conversation
tj098895
commented
May 7, 2026
|
|
||
| class ProcessUnit(Entity[ProcessUnitId], StreamPropagator, abc.ABC): | ||
| @abc.abstractmethod | ||
| class ProcessUnit[TSnapshot](Entity[ProcessUnitId], StreamPropagator, abc.ABC): |
Contributor
Author
There was a problem hiding this comment.
TSnapshot, or TInput and TOutput? for a snapshot?
tj098895
commented
May 7, 2026
|
|
||
| class Compressor(ProcessUnit): | ||
| @value_object | ||
| class OperatingPoint: |
Contributor
Author
There was a problem hiding this comment.
correct "input params"?
tj098895
commented
May 7, 2026
|
|
||
| @value_object | ||
| class CompressorSnapshot: | ||
| outlet_stream: FluidStream |
Contributor
Author
There was a problem hiding this comment.
relevant "minimum" output params?
Contributor
|
This PR is stale because it has been open for 7 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Work
See here (internal): https://github.com/equinor/ecalc-internal/discussions/1044
Have you remembered and considered?
docs/drafts/next.draft.md)docs/docs/migration_guides/)BREAKING:in footer or!in headerWhat is this PR all about?
What else did you consider?
Between the lines?