ENH: Avoid repeated name normalization during matching - #461
Open
GibranAlfa wants to merge 3 commits into
Open
Conversation
GibranAlfa
force-pushed
the
speed-up-matching-comparison
branch
from
August 24, 2026 13:21
8031d35 to
c5e0747
Compare
tnatt
reviewed
Aug 24, 2026
tnatt
left a comment
Contributor
There was a problem hiding this comment.
Nice speedup 🥳
I just have some comments regarding tests - I feel like we might not test too many variants of different strings. Probably worth adding some more.
GibranAlfa
force-pushed
the
speed-up-matching-comparison
branch
from
August 26, 2026 12:42
514d479 to
559f97e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #460
Normalize each source and target name once per matching request, then use RapidFuzz extraction to calculate scores and select the top three matches.
Time to compare 1550 wells is reduced from 159 seconds to 220 miliseconds 🤯.
Checklist
--cov=src/ --cov-report term-missing)