ENH: Add original I,J,K as properties in NestedHybridGrid - #492
Open
nourinmohd wants to merge 3 commits into
Open
ENH: Add original I,J,K as properties in NestedHybridGrid#492nourinmohd wants to merge 3 commits into
nourinmohd wants to merge 3 commits into
Conversation
Contributor
Author
|
# Conflicts: # src/fmu/tools/nestedhybridgrid/nestedhybrid.py
nourinmohd
force-pushed
the
470_add_ijk_properties
branch
from
August 21, 2026 08:31
499b863 to
db7e53a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #470
Adds preservation of original grid I/J/K coordinates for
NestedHybridGrid._build_nested_hybrid_grid()now appendsI_orig, J_orig, andK_origproperties to the coarse grid before refinement and merge, allowingxtgeo.grid_merge()to transfer them automatically to the final nested hybrid grid. These properties are available throughnhg.propertiesandnhg.grid.get_prop_by_name(...).Also updates the nested hybrid grid property test to verify the new properties are present and retain the original 1-based coordinates.
Checklist
--cov=src/ --cov-report term-missing)