Skip to content

ENH: Add original I,J,K as properties in NestedHybridGrid - #492

Open
nourinmohd wants to merge 3 commits into
equinor:mainfrom
nourinmohd:470_add_ijk_properties
Open

ENH: Add original I,J,K as properties in NestedHybridGrid#492
nourinmohd wants to merge 3 commits into
equinor:mainfrom
nourinmohd:470_add_ijk_properties

Conversation

@nourinmohd

@nourinmohd nourinmohd commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Resolves #470

  • Adds preservation of original grid I/J/K coordinates for NestedHybridGrid.

  • _build_nested_hybrid_grid() now appends I_orig, J_orig, and K_orig properties to the coarse grid before refinement and merge, allowing xtgeo.grid_merge() to transfer them automatically to the final nested hybrid grid. These properties are available through nhg.properties and nhg.grid.get_prop_by_name(...).

  • Also updates the nested hybrid grid property test to verify the new properties are present and retain the original 1-based coordinates.

Checklist

  • Tests added (if not, comment why)
  • Test coverage equal or up from main (run pytest with --cov=src/ --cov-report term-missing)
  • If not squash merging, every commit passes tests
  • Appropriate commit prefix and precise commit message used
  • All debug prints and unnecessary comments removed
  • Docstrings are correct and updated
  • Documentation is updated, if necessary
  • Latest main rebased/merged into branch
  • Added comments on this PR where appropriate to help reviewers
  • Moved issue status on project board
  • Checked the boxes in this checklist ✅

@nourinmohd
nourinmohd requested a review from tnatt August 19, 2026 07:58
@nourinmohd

Copy link
Copy Markdown
Contributor Author
  • Add a constant for the I_org, J_org, and K_org instead of passing them as strings.

@nourinmohd
nourinmohd force-pushed the 470_add_ijk_properties branch from 499b863 to db7e53a Compare August 21, 2026 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add original I,J,K as properties in the NestedHybridGrid

1 participant