Remove copen - #1284
Open
eivindjahren wants to merge 8 commits into
Open
Conversation
eivindjahren
force-pushed
the
remove_copen
branch
2 times, most recently
from
August 28, 2026 10:43
4d1967e to
b8c1ff3
Compare
This avoids a object lifetime bug in geo_polygon_collection
eivindjahren
force-pushed
the
remove_copen
branch
from
August 28, 2026 10:48
b8c1ff3 to
d285ace
Compare
This makes a change to the logic of fseek_grdecl. The c code would rewind to the start of the line when doing a fseek, however, that is not safe with python text streams which can be utf-8. Therefore we have to assume that the stream is at the start of a line or valid keyword and it is up to the caller to ensure that.
eivindjahren
force-pushed
the
remove_copen
branch
from
August 28, 2026 11:20
d285ace to
c1e08ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes all usage of cwrap.open and replace it with python code. We go by a conversion to fd for testing purposes only.