Stop passing the unused integration test secret - #488
Open
oysand wants to merge 1 commit into
Open
Conversation
oysand
force-pushed
the
stop-passing-unused-integration-test-secret
branch
from
August 25, 2026 10:30
15fc0b7 to
8efa0f4
Compare
andchiind
approved these changes
Aug 26, 2026
oysand
force-pushed
the
stop-passing-unused-integration-test-secret
branch
from
August 27, 2026 12:14
8efa0f4 to
02d24b9
Compare
This was referenced Aug 27, 2026
oysand
force-pushed
the
stop-passing-unused-integration-test-secret
branch
from
August 27, 2026 12:30
02d24b9 to
d3bf417
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
INTEGRATION_TEST_AZURE_CLIENT_SECRETexisted so the armada integration tests could read the MQTT credentials fromFlotillaTestsKv. As of equinor/armada#100 those credentials are generated per test run and nothing is read from the key vault, so passing this secret does nothing.Removing it here is what lets armada drop the declaration — GitHub rejects a caller passing a secret the reusable workflow does not declare, so the callers have to go first — and lets the secret and its service principal be retired.
No behaviour change: the workflow already ignores it.
Depends on
equinor/armada#100 should merge first, so the workflow has stopped reading it.
Ready for review checklist:
Merge order
This is one of five PRs that remove the need for any external secret to run the armada
integration tests. They must merge in this order:
Make the MQTT CA certificate configurable isar#1166 — MQTT CA certificate configurable
then wait for the
:devimages to publishOut of order it breaks: armada's reusable workflow currently declares
INTEGRATION_TEST_AZURE_CLIENT_SECRETasrequired: trueand every caller uses@main, so acaller that stops passing it before step 2 fails immediately. Conversely step 2 needs the new
broker and the configurable ISAR CA already published, because it feeds the broker its
credentials through the environment.