feat: add zkVMProver::execute_estimated_cost with impls for all 3 zkVMs - #416
Merged
Conversation
han0110
force-pushed
the
han/feature/cost-estimator
branch
from
August 28, 2026 08:31
6cafc8a to
48088a9
Compare
han0110
marked this pull request as draft
August 28, 2026 10:52
han0110
force-pushed
the
han/feature/cost-estimator
branch
from
August 28, 2026 10:57
48088a9 to
c0e2d44
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zkVMProver::execute_estimated_cost(&self, input)that returns(PublicValues, CostEstimation), naming it withexecute_prefix explicitly so people could be aware it's estimated by full execution with additional cost metering.RvrMeteredInstance, which counts trace height of each AIR, and the cost unit is purely cell countGasEstimatingVMEnum, which counts rows of each category, and the cost unit is weighted by cell and constraints complexity