Repository navigation
Carry the sweep's amplitude scale across rebuilds and expose it - #16
Merged
Merged
Conversation
ShmemSweepWidget takes amplitude_scale, autoscale and y_range alongside display_dur, hands them to phosphor's SweepConfig, and keeps all four across a plot rebuild. The sweep_scale property returns the values in force, keyed like __init__, so an application can remember them without reaching into the sweep buffer. Requires phosphor 0.13.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ShmemSweepWidgetacceptsamplitude_scale,autoscaleandy_rangealongsidedisplay_dur, passes them into phosphor'sSweepConfig, and keeps all four across a plot rebuild (previously onlydisplay_dursurvived). A non-rebuild reconfigure also keeps the live values now instead of resettingdisplay_durto the constructor's.New read-only
sweep_scaleproperty returns the values in force — the live plot's, or the configured ones before the plot exists — keyed like__init__, so an application can persist and restore them (ShmemSweepWidget(name, **saved)) without reaching intosweep.sweep_buffer.Requires phosphor 0.13 (ezmsg-org/phosphor PR for initial
autoscale/y_range); the floor is bumped tophosphor>=0.13.0, so this needs that release first.