Skip to content

Carry the sweep's amplitude scale across rebuilds and expose it - #16

Merged
cboulay merged 1 commit into
mainfrom
feat/sweep-initial-scale
Nov 4, 2026
Merged

cboulay merged 1 commit into
mainfrom
feat/sweep-initial-scale

Conversation

@cboulay

@cboulay cboulay commented Nov 4, 2026

Copy link
Copy Markdown
Member

ShmemSweepWidget accepts amplitude_scale, autoscale and y_range alongside display_dur, passes them into phosphor's SweepConfig, and keeps all four across a plot rebuild (previously only display_dur survived). A non-rebuild reconfigure also keeps the live values now instead of resetting display_dur to the constructor's.

New read-only sweep_scale property returns the values in force — the live plot's, or the configured ones before the plot exists — keyed like __init__, so an application can persist and restore them (ShmemSweepWidget(name, **saved)) without reaching into sweep.sweep_buffer.

Requires phosphor 0.13 (ezmsg-org/phosphor PR for initial autoscale/y_range); the floor is bumped to phosphor>=0.13.0, so this needs that release first.

ShmemSweepWidget takes amplitude_scale, autoscale and y_range alongside
display_dur, hands them to phosphor's SweepConfig, and keeps all four
across a plot rebuild. The sweep_scale property returns the values in
force, keyed like __init__, so an application can remember them without
reaching into the sweep buffer. Requires phosphor 0.13.
@cboulay
cboulay merged commit 5129e65 into main Nov 4, 2026
14 of 31 checks passed
@cboulay
cboulay deleted the feat/sweep-initial-scale branch November 4, 2026 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant