Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/guid-index.json
Original file line number Diff line number Diff line change
Expand Up @@ -875,7 +875,7 @@
"path": ".github/workflows/ci-tests.yml",
"guid": "ci-tests-workflow-2025-automation",
"title": "CI Self Tests",
"version": "1.2.2",
"version": "1.2.3",
"header_path": ".github/workflows/ci-tests.yml",
"path_mismatch": false
},
Expand Down Expand Up @@ -939,15 +939,15 @@
"path": ".github/workflows/performance-monitoring.yml",
"guid": "performance-monitoring-workflow-2025",
"title": "Performance Monitoring",
"version": "1.1.4",
"version": "1.1.5",
"header_path": ".github/workflows/performance-monitoring.yml",
"path_mismatch": false
},
{
"path": ".github/workflows/pr-automation.yml",
"guid": "a7b8c9d0-e1f2-3456-a789-0123456789bc",
"title": "PR Automation",
"version": "4.5.9",
"version": "4.5.10",
"header_path": ".github/workflows/pr-automation.yml",
"path_mismatch": false
},
Expand Down Expand Up @@ -979,7 +979,7 @@
"path": ".github/workflows/reusable-ci.yml",
"guid": "reusable-ci-2025-09-24-core-workflow",
"title": "Reusable CI Workflow",
"version": "1.20.0",
"version": "1.20.1",
"header_path": ".github/workflows/reusable-ci.yml",
"path_mismatch": false
},
Expand Down
10 changes: 7 additions & 3 deletions .github/workflows/ci-tests.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# file: .github/workflows/ci-tests.yml
# version: 1.2.2
# version: 1.2.3
# guid: ci-tests-workflow-2025-automation
# last-edited: 2026-10-20
# last-edited: 2026-11-06

name: CI Self Tests

Expand Down Expand Up @@ -80,7 +80,11 @@ jobs:
submodules: recursive

- name: Install Rust stable
uses: dtolnay/rust-toolchain@683b588c487a69d01f6c6ddf40f036ff682cc2c8 # stable
# This SHA is the action's master branch, which has no default toolchain:
# without `toolchain` the step fails with "'toolchain' is a required input".
uses: dtolnay/rust-toolchain@683b588c487a69d01f6c6ddf40f036ff682cc2c8 # master
with:
toolchain: stable

- name: Restore cargo cache
uses: Swatinem/rust-cache@d1527c8f67ef9af357290475d4af4b0fab8f12e0 # v2.9.3
Expand Down
9 changes: 7 additions & 2 deletions .github/workflows/performance-monitoring.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# file: .github/workflows/performance-monitoring.yml
# version: 1.1.4
# version: 1.1.5
# guid: performance-monitoring-workflow-2025
# last-edited: 2026-11-06

name: Performance Monitoring

Expand Down Expand Up @@ -33,7 +34,11 @@ jobs:
submodules: recursive

- name: Install toolchain
uses: dtolnay/rust-toolchain@683b588c487a69d01f6c6ddf40f036ff682cc2c8 # stable
# This SHA is the action's master branch, which has no default toolchain:
# without `toolchain` the step fails with "'toolchain' is a required input".
uses: dtolnay/rust-toolchain@683b588c487a69d01f6c6ddf40f036ff682cc2c8 # master
with:
toolchain: stable

- name: Restore cache
uses: Swatinem/rust-cache@d1527c8f67ef9af357290475d4af4b0fab8f12e0 # v2.9.3
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/pr-automation.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# file: .github/workflows/pr-automation.yml
# version: 4.5.9
# version: 4.5.10
# guid: a7b8c9d0-e1f2-3456-a789-0123456789bc
# NOTE: This file should be updated in ghcommon repository first, then copied to other repositories.
# To update: Edit in https://github.com/falkcorp/github-common/.github/workflows/pr-automation.yml then copy to other repos
Expand Down Expand Up @@ -95,7 +95,7 @@ jobs:

- name: Setup Rust (if Cargo.toml present)
if: steps.detect_langs.outputs.rust_present == 'true'
uses: dtolnay/rust-toolchain@683b588c487a69d01f6c6ddf40f036ff682cc2c8 # stable
uses: dtolnay/rust-toolchain@683b588c487a69d01f6c6ddf40f036ff682cc2c8 # master
with:
toolchain: stable
components: rustfmt, clippy
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/reusable-ci.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# file: .github/workflows/reusable-ci.yml
# version: 1.20.0
# version: 1.20.1
# guid: reusable-ci-2025-09-24-core-workflow
# last-edited: 2026-11-04
# last-edited: 2026-11-06

name: Reusable CI Workflow

Expand Down Expand Up @@ -816,7 +816,7 @@ jobs:
submodules: recursive

- name: Set up Rust
uses: dtolnay/rust-toolchain@683b588c487a69d01f6c6ddf40f036ff682cc2c8 # stable
uses: dtolnay/rust-toolchain@683b588c487a69d01f6c6ddf40f036ff682cc2c8 # master
with:
toolchain: ${{ matrix.rust-version }}
components: rustfmt, clippy
Expand Down
11 changes: 11 additions & 0 deletions changelog.d/20261106_rust_toolchain_input.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
### Fixed

#### `ci-tests.yml`, `performance-monitoring.yml`: Rust Benchmarks pass the toolchain

`dtolnay/rust-toolchain` is pinned to a SHA on the action's `master` branch,
which has no default toolchain. The two Rust Benchmarks jobs called it without
`toolchain`, so the step failed with `'toolchain' is a required input` and
CI Self Tests and Performance Monitoring were red on every run since
February 2026. Both now pass `toolchain: stable`. The pin comment in all four
workflows that use the action said `# stable`; it now says `# master`, which
is what the SHA is.
Loading