Fix Rich help terminal width - #1945
Open
AIlord1501 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Discussion: #1944
Description
Problem
When Typer renders help using Rich,
CliRunner(..., terminal_width=...)was not respected.The requested terminal width is stored in the Click context as
ctx.terminal_width, but the Rich console was usingMAX_WIDTHinstead. This caused Rich-formatted help output to exceed the terminal width requested byCliRunner.Fix
Pass
ctx.terminal_widthto Typer's Rich console when formatting help.The existing
MAX_WIDTHbehavior remains the fallback when no explicit width is provided.Tests
Added a regression test verifying that Rich-formatted help respects the terminal width supplied through
CliRunner.Full test suite:
AI Disclaimer
This pull request was developed with assistance from an AI coding assistant (GPT-5.6 Luna).
AI transcript
Checklist