Repository navigation
fix(security): PAT org binding, subscribe throttle, invite lookup, SNMP secret - #699
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…gn-in factor A personal access token could call switch-org to get a full session in any org of its owner, approve a device grant for another org, and add sign-in factors (passkey, password, 2FA). RequireAuth now refuses those routes to a PAT with 403 PAT_FORBIDDEN, startSession refuses to mint a session from a PAT request, and registering a passkey emails the owner. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #699 +/- ##
==========================================
+ Coverage 89.72% 89.74% +0.01%
==========================================
Files 1292 1295 +3
Lines 131787 131964 +177
==========================================
+ Hits 118247 118432 +185
+ Misses 13531 13523 -8
Partials 9 9
🚀 New features to boost your workflow:
|
…llow the PAT binding Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…the owner's other orgs and add sign-in factors Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ry and confirm-mail budget config
status_page_subscriber.confirm_sent_at records when the current confirm
token was issued; DeleteExpiredUnconfirmedSubscribers reaps never-confirmed
rows past it. SP_STATUS_SUBSCRIBERS_CONFIRM_PER_{RECIPIENT,PAGE,IP}_PER_HOUR
budget the double opt-in mail (defaults 3, 100, 20).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…bscribers confirmed The public subscribe endpoint no longer mails on every call: the confirm mail is budgeted per recipient (all pages), per page and per trusted client IP, and a live confirmed subscription is left untouched by a repeat subscribe. Both cases still answer 202 pending_confirmation, so the endpoint reveals nothing. Confirm links expire after 7 days and the state-cleanup job reaps the unconfirmed rows. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…kup out of Subscribe Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…rottled confirm emails and un-confirms existing subscribers Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…rg scan
The public GET /auth/invite/:token and anonymous POST /auth/accept-invite
loaded every organization and probed two state entries per org, so an
unknown token cost about 2 x N + 1 queries. CreateInvitation now also
writes a global index entry (invite:<hash>, no organization, value
{orgUID}); findInvite reads it, then the org-scoped entry. Acceptance,
federated join and revocation delete both. The legacy plaintext-key branch
(TODO remove after 2026-10-10) is gone.
Operator action: invitations created before this release have no index
entry and are no longer found; admins must re-send them.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…s every organization Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Declare community in SNMPConfig.SecretFields so it is encrypted, redacted from GET/export/snapshots, and rendered as a password input in dash0. credmigrate.RunPlaintext runs at every startup and re-splits rows whose private column is empty, so existing v1/v2c rows move automatically; past version snapshots are scrubbed on read via HiddenConfigKeys. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…urned as public check config Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security fixes from the daily security scans (specs filed in this PR, now implemented).
What changed
switch-org, mint sessions or device-consent tokens, or change sign-in factors (password, 2FA, passkeys, email). It gets 403PAT_FORBIDDEN.sp auth switch-orgon a PAT login explains what to do. Registering a passkey now emails the owner.SP_STATUS_SUBSCRIBERS_CONFIRM_PER_*_PER_HOUR). Unconfirmed rows expire after 7 days (new columnconfirm_sent_atin migration 031).Decided by autopilot
switch-org: not allowed at all (recommended answer).DELETE /auth/2fakeeps sharing the login budget (recommended answer).🤖 Generated with Claude Code