[fclairamb]

Fixes the findings of the daily security scans. Each spec is the tracker for its finding.

Fixed by this PR

• Y1 (low): specs/done/2026/10/2026-10-29-01-bug-report-upload-instance-budget.md. Anonymous bug-report screenshots are capped at 100 MB per org, but the caller picks the org, so the instance-wide total is 100 MB times the number of orgs. Screenshots are also stored past the issue-dispatch cap and never deleted. The fix adds an instance-wide budget for anonymous screenshots, reserves the dispatch slot before storing, makes the quota atomic and adds a retention.

Earlier scan specs (implemented, in specs/done/2026/10/)

• X1 (high): 2026-10-28-01-pat-cannot-mint-sessions-or-sign-in-factors.md. A PAT could open sessions in its owner's other orgs and add sign-in factors. Fixed in fix(security): PAT org binding, subscribe throttle, invite lookup, SNMP secret #699.
• X2 (medium): 2026-10-28-02-status-subscribe-throttle-and-keep-confirmed.md. Unthrottled subscribe confirm emails, and re-subscribing un-confirmed a subscriber. Fixed in fix(security): PAT org binding, subscribe throttle, invite lookup, SNMP secret #699.
• X3 (medium on SaaS): 2026-10-28-03-invite-lookup-without-org-scan.md. Invite lookup scanned every org. Fixed in fix(security): PAT org binding, subscribe throttle, invite lookup, SNMP secret #699.
• X4 (low): 2026-10-28-04-snmp-community-secret-field.md. The SNMP community was not a secret field. Fixed in fix(security): PAT org binding, subscribe throttle, invite lookup, SNMP secret #699.
• V1 (medium): 2026-10-27-01-device-consent-phishing-guard.md. Device-flow consent phishing. Fixed in fix(security): device consent phishing guard and 2FA disable throttle #693.
• W1 (low): 2026-10-27-02-disable-2fa-attempt-throttle.md. DELETE /auth/2fa had no attempt budget. Fixed in fix(security): device consent phishing guard and 2FA disable throttle #693.
• U1 (low): 2026-10-26-02-ai-repair-hold-skips-param-only-secrets.md. The repair: auto hold applied only when the check's secrets map had a value. Fixed in fix(ai): hold every scheduled repair-auto run to its granted hosts #683.
• S1 (medium): 2026-10-25-01-ai-repair-grant-dropped-by-reference-resolution.md. The repair grant was compared after ${…} references were resolved. Fixed in fix(ai): hold the repair: auto host grant when the script or env holds a reference #678; U1 closed the remaining gap.
• R1 (medium): 2026-10-24-01-ai-repair-auto-apply-partial-runtime-host.md. repair: auto applied a candidate that kept a literal host and added one built at runtime. Fixed in feat(ai): hold auto-applied repairs to the previous version's hosts (+ scan specs) #663.
• Q1 (medium): 2026-10-23-02-ai-loop-secret-relay-through-model.md. AI loops relayed an encoded secret through the model.
• P1 (medium): 2026-10-22-01-ai-script-secret-host-guard-runtime.md. AI runs with real secrets were only host-checked by regex.
• K1 (medium): 2026-10-20-01-sender-response-body-caps.md. Notification senders and RabbitMQ read responses uncapped.
• J1 (medium): 2026-10-19-01-a2a-response-size-cap.md. A2A responses were read uncapped.
• I1 (low): 2026-10-18-01-plugin-schema-file-ref.md. Plugin schema $ref could load local files.
• G1/G2 (low): 2026-10-17-01-postgres-check-connection-config.md. Postgres conninfo escaping and fallback to the worker's PG* env.
• F1: 2026-10-16-15-pat-cache-revocation.md. The PAT cache outlived revocation.
• E1: 2026-10-16-14-totp-on-federated-sign-in.md. No TOTP on federated sign-in.
• E2: 2026-10-16-13-atomic-auth-attempt-counters.md. Auth attempt counters were not atomic.
• H3: 2026-10-16-12-mcp-tokens-rejected-on-rest.md. MCP OAuth tokens worked on REST.
• H2: 2026-10-16-11-slack-signature-fail-closed.md. Slack signature check failed open.
• T1 / M2 (high): 2026-10-16-10-discovery-scans-egress-guard.md. Discovery scans were outside the egress policy.
• N4: 2026-10-16-09-js-check-nested-docker-guard.md. A JS docker sub-check bypassed the gate.
• N3 (high): 2026-10-16-08-status-page-components-cross-org.md. Status-page components could be edited across orgs.
• D2/D3 (high): 2026-10-16-07-guard-status-subscriber-and-publication-webhooks.md. Subscriber and publication webhooks were not guarded.
• C3: 2026-10-16-06-accept-invite-existing-account.md. Accepting an invite logged in as an existing account.
• C1: 2026-10-16-05-kubeconfig-exec-and-incluster.md. Kubeconfig exec and inCluster were allowed.
• N2: 2026-10-16-04-mysql-dsn-injection.md. MySQL DSN injection.
• N1: 2026-10-16-03-env-secret-reference-allowlist.md. No allowlist for ${env:} references.
• C2/H1: 2026-10-16-02-token-purpose-separation.md. Purpose tokens were accepted as access tokens.
• D1: 2026-10-16-01-microsoft-signin-unverified-email-linking.md. Microsoft nOAuth email linking.

🤖 Generated with Claude Code

[codecov]

Codecov Report

❌ Patch coverage is 92.25352% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.75%. Comparing base (e1a6e94) to head (7ba7c6b).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
server/internal/handlers/feedback/service.go	88.60%	9 Missing ⚠️
server/internal/jobs/jobtypes/job_state_cleanup.go	90.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #708      +/-   ##
==========================================
- Coverage   89.77%   89.75%   -0.02%     
==========================================
  Files        1296     1296              
  Lines      132089   132195     +106     
==========================================
+ Hits       118580   118650      +70     
- Misses      13500    13536      +36     
  Partials        9        9              

Files with missing lines	Coverage Δ
server/internal/app/server.go	92.02% <ø> (ø)
server/internal/config/config.go	94.05% <100.00%> (+0.05%)	⬆️
server/internal/config/envvars.go	100.00% <100.00%> (ø)
server/internal/db/postgres/postgres.go	94.85% <100.00%> (-0.06%)	⬇️
server/internal/db/sqlite/sqlite.go	96.66% <100.00%> (+0.01%)	⬆️
server/internal/handlers/feedback/handler.go	81.94% <100.00%> (+0.51%)	⬆️
server/internal/jobs/jobtypes/job_state_cleanup.go	88.60% <90.00%> (+0.47%)	⬆️
server/internal/handlers/feedback/service.go	88.77% <88.60%> (+6.65%)	⬆️

... and 11 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.