Remove a part of next README.md that throw error on build test - #395
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @2chanhaeng, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a build test failure originating from the packages/next/README.md file. The changes ensure that the documentation no longer causes errors during the build process, improving the stability of the project's build pipeline.
Highlights
- Documentation Fix: Modified packages/next/README.md to resolve a build test error.
- Code Block Correction: Added the "ignore" flag to a TypeScript code block in the README to prevent it from being processed during build tests.
- Redundant Code Removal: Removed a large section of TypeScript integration code from the README that was causing build failures.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request resolves a build failure by removing a large, outdated code block from packages/next/README.md and adding an ignore directive to another code snippet. While these changes successfully fix the build, the removal of the documentation block creates a gap in explaining the package's functionality. I have included a review comment suggesting that a reference to the source code be added to guide users to the up-to-date implementation details.
|
The latest push to this pull request has been published to JSR and npm as a pre-release:
|
|
The docs for this pull request have been published: |
Summary
Remove a part of next README.md that throw error on build test
Related Issue
Changes
packages/next/README.mdBenefits
No error on build test.
Checklist
deno task test-allon your machine?Additional Notes