Skip to content

Remove a part of next README.md that throw error on build test - #395

Merged
dahlia merged 1 commit into
fedify-dev:mainfrom
2chanhaeng:next/fix
Aug 31, 2025
Merged

Remove a part of next README.md that throw error on build test#395
dahlia merged 1 commit into
fedify-dev:mainfrom
2chanhaeng:next/fix

Conversation

@2chanhaeng

Copy link
Copy Markdown
Member

Summary

Remove a part of next README.md that throw error on build test

Related Issue

Changes

  • packages/next/README.md

Benefits

No error on build test.

Checklist

  • Did you add a changelog entry to the CHANGES.md?
  • Did you write some relevant docs about this change (if it's a new feature)?
  • Did you write a regression test to reproduce the bug (if it's a bug fix)?
  • Did you write some tests for this change (if it's a new feature)?
  • Did you run deno task test-all on your machine?

Additional Notes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @2chanhaeng, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a build test failure originating from the packages/next/README.md file. The changes ensure that the documentation no longer causes errors during the build process, improving the stability of the project's build pipeline.

Highlights

  • Documentation Fix: Modified packages/next/README.md to resolve a build test error.
  • Code Block Correction: Added the "ignore" flag to a TypeScript code block in the README to prevent it from being processed during build tests.
  • Redundant Code Removal: Removed a large section of TypeScript integration code from the README that was causing build failures.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request resolves a build failure by removing a large, outdated code block from packages/next/README.md and adding an ignore directive to another code snippet. While these changes successfully fix the build, the removal of the documentation block creates a gap in explaining the package's functionality. I have included a review comment suggesting that a reference to the source code be added to guide users to the up-to-date implementation details.

@github-actions

Copy link
Copy Markdown
Contributor

The latest push to this pull request has been published to JSR and npm as a pre-release:

Package Version JSR npm
@fedify/fedify 1.9.0-pr.395.1481+1d27e9b8 JSR npm
@fedify/cli 1.9.0-pr.395.1481+1d27e9b8 JSR
@fedify/amqp 1.9.0-pr.395.1481+1d27e9b8 JSR npm
@fedify/cfworkers 1.9.0-pr.395.1481+1d27e9b8 JSR npm
@fedify/denokv 1.9.0-pr.395.1481+1d27e9b8 JSR
@fedify/elysia 1.9.0-pr.395.1481+1d27e9b8 npm
@fedify/express 1.9.0-pr.395.1481+1d27e9b8 JSR npm
@fedify/h3 1.9.0-pr.395.1481+1d27e9b8 JSR npm
@fedify/hono 1.9.0-pr.395.1481+1d27e9b8 JSR npm
@fedify/nestjs 1.9.0-pr.395.1481+1d27e9b8 npm
@fedify/next 1.9.0-pr.395.1481+1d27e9b8 npm
@fedify/postgres 1.9.0-pr.395.1481+1d27e9b8 JSR npm
@fedify/redis 1.9.0-pr.395.1481+1d27e9b8 JSR npm
@fedify/sqlite 1.9.0-pr.395.1481+1d27e9b8 JSR npm
@fedify/sveltekit 1.9.0-pr.395.1481+1d27e9b8 JSR npm
@fedify/testing 1.9.0-pr.395.1481+1d27e9b8 JSR npm

@github-actions

Copy link
Copy Markdown
Contributor

The docs for this pull request have been published:

https://1d248c3b.fedify.pages.dev

@dahlia
dahlia merged commit 542d3bc into fedify-dev:main Aug 31, 2025
19 of 20 checks passed
@2chanhaeng
2chanhaeng deleted the next/fix branch December 18, 2025 11:33
@dahlia dahlia added the integration/next Next.js integration (@fedify/next) label Jan 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/integration Web framework integration integration/next Next.js integration (@fedify/next) status/in progress In progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants