Fix fedify/next test-each failure, add fedify/next tests by Bananamilk452 · Pull Request #978 · fedify-dev/fedify

Bananamilk452 · 2026-08-01T05:58:23Z

Closes #976, #869, #870, #868, #866, #867

Description

Added a comprehensive test suite in packages/next/src/index.test.ts to cover federation request detection, NodeInfo route handling, middleware delegation, and custom error handling logic.
Modified the mise.toml test runner to only run Deno tests if a deno.json file exists for the package, and to always run Node.js and Bun tests with clear output messages.

Github Copilot helped me making title of this PR, gpt-5.6-terra helped checking code quality and code creation.

netlify · 2026-08-01T05:58:27Z

✅ Deploy Preview for fedify-json-schema canceled.

Name	Link
🔨 Latest commit	`6f7a221`
🔍 Latest deploy log	https://app.netlify.com/projects/fedify-json-schema/deploys/6a72dedb4ba1c00008897529

coderabbitai · 2026-08-01T05:58:30Z

📝 Walkthrough

Walkthrough

The pull request adds Next.js integration tests for request routing and custom handlers. It adds Node.js and Bun test scripts. The shared test-each task selects checks by package manifest, and Deno excludes the Next.js package.

Changes

Next.js runtime tests

Layer / File(s)	Summary
Request handling test coverage `packages/next/src/index.test.ts`	Adds tests for ActivityPub request detection, NodeInfo routes, middleware delegation, and custom not-found and not-acceptable handlers.
Runtime-specific test execution `packages/next/package.json`, `deno.json`, `mise.toml`	Adds Node.js and Bun test scripts. Excludes the Next.js package from Deno tests. Gates shared test commands by `deno.json` and `package.json`.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related issues

Test NodeInfo route detection in @fedify/next #868 — Adds NodeInfo route detection tests in packages/next/src/index.test.ts.

Possibly related PRs

fedify-dev/fedify#936 — Adds related Astro compatibility testing workflow and mise test integration.
fedify-dev/fedify#977 — Modifies the same test file and adds related federation request detection tests.

Suggested labels: runtime/node, runtime/bun, component/integration

Suggested reviewers: dahlia

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly identifies the test-each fix and the added fedify/next tests.
Description check	✅ Passed	The description directly explains the added tests and the mise.toml test-runner changes.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

codecov · 2026-08-01T06:10:00Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:

📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

2chanhaeng · 2026-08-01T06:19:25Z

Next.js does not work well with Deno. Seriously. Instead of adding deno.json to @fedify/next to enable Deno support, could you modify it to exclude cases where deno.json is missing within the package path received during test-each/check-each tasks, or when the package path is not included in the workspace of the root deno.json?

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@mise.toml`:
- Around line 308-312: Update the package loop condition around the Deno
commands to require both the package-local packages/($pkg)/deno.json and
membership in the root deno.json workspace; only then run mise run check-each
and deno task --filter. Keep packages lacking either configuration out of this
Deno task path.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 25562d94-d015-474f-ad9a-4ec3cfec14cd

📥 Commits

Reviewing files that changed from the base of the PR and between 9b6f025 and b84059d.

⛔ Files ignored due to path filters (1)

deno.lock is excluded by !**/*.lock

📒 Files selected for processing (3)

mise.toml
packages/next/package.json
packages/next/src/index.test.ts

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packages/next/src/index.test.ts`:
- Around line 6-7: Replace the test import from `@fedify/fixture` with Node’s
built-in test harness by importing test from node:test in the package test file,
while preserving the existing assertions and test behavior.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 2292e827-1479-4eeb-a805-b0a3e002baf4

📥 Commits

Reviewing files that changed from the base of the PR and between b84059d and fe605d1.

📒 Files selected for processing (3)

mise.toml
packages/next/package.json
packages/next/src/index.test.ts

2chanhaeng

Great work! Please check the point that I commented on.

2chanhaeng

Please add packages/next to test.exclude in root deno.json

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packages/next/package.json`:
- Line 62: Update the test scripts in packages/next/package.json by adding
pretest and pretest:bun hooks that run pnpm build, matching the packages/amqp
pattern so dist/ is built before pnpm test or the Bun test command executes.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 907b44d1-6698-4b78-8c5d-8e8ed8bdf9cc

📥 Commits

Reviewing files that changed from the base of the PR and between fe605d1 and c933943.

📒 Files selected for processing (3)

deno.json
mise.toml
packages/next/package.json

Bananamilk452 · 2026-08-04T08:29:58Z

I made a change! Please take an another look!

2chanhaeng

Great work! Thanks for your contribution!

2chanhaeng · 2026-08-05T05:25:47Z

Oh, before merging this PR, please rebase from the main branch. Thanks!

- add next as dependency and deno.json - skip Deno tests for packages without deno.json - add test scripts in next/package.json Assisted-by: OpenCode:gpt-5.6-terra

Assisted-by: OpenCode:gpt-5.6-terra

coderabbitai · 2026-08-05T06:57:40Z

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

Bananamilk452 force-pushed the fedify-next-tests branch 2 times, most recently from 8b26d33 to b84059d Compare August 1, 2026 06:57

Bananamilk452 marked this pull request as ready for review August 1, 2026 06:58

Bananamilk452 requested review from 2chanhaeng and dahlia as code owners August 1, 2026 06:58

coderabbitai Bot reviewed Aug 1, 2026

View reviewed changes

Comment thread mise.toml

Bananamilk452 force-pushed the fedify-next-tests branch from b84059d to fe605d1 Compare August 1, 2026 07:02

coderabbitai Bot reviewed Aug 1, 2026

View reviewed changes

Comment thread packages/next/src/index.test.ts

2chanhaeng requested changes Aug 2, 2026

View reviewed changes

Comment thread mise.toml Outdated

2chanhaeng requested changes Aug 2, 2026

View reviewed changes

Comment thread packages/next/package.json Outdated

coderabbitai Bot reviewed Aug 4, 2026

View reviewed changes

Comment thread packages/next/package.json

2chanhaeng previously approved these changes Aug 5, 2026

View reviewed changes

Bananamilk452 dismissed 2chanhaeng’s stale review via c933943 August 5, 2026 06:57

Bananamilk452 force-pushed the fedify-next-tests branch from 36928d9 to c933943 Compare August 5, 2026 06:57

Bananamilk452 added 7 commits August 5, 2026 15:57

Fix fedify/next test-each failure

3dbd090

- add next as dependency and deno.json - skip Deno tests for packages without deno.json - add test scripts in next/package.json Assisted-by: OpenCode:gpt-5.6-terra

Add Accept header detection test in fedify/next

45ec80f

Add Content-Type header detection test in fedify/next

e303b17

Add NodeInfo route detection test in fedify/next

eae229c

Add non-federation request delegation test in fedify/next

f3e2434

Add custom not found/not acceptable handler

ccddfbf

Assisted-by: OpenCode:gpt-5.6-terra

Edit deno.json, mise.toml, package.json to fix test in fedify/next

6f7a221

Bananamilk452 force-pushed the fedify-next-tests branch from c933943 to 6f7a221 Compare August 5, 2026 06:57

2chanhaeng approved these changes Aug 5, 2026

View reviewed changes

dahlia approved these changes Aug 5, 2026

View reviewed changes

dahlia merged commit 15ad151 into fedify-dev:main Aug 5, 2026
25 checks passed

Uh oh!

Uh oh!

Conversation

Bananamilk452 commented Aug 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

netlify Bot commented Aug 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for fedify-json-schema canceled.

Uh oh!

coderabbitai Bot commented Aug 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

codecov Bot commented Aug 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

2chanhaeng commented Aug 1, 2026

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

2chanhaeng left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

2chanhaeng left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Bananamilk452 commented Aug 4, 2026

Uh oh!

2chanhaeng left a comment

Choose a reason for hiding this comment

Uh oh!

2chanhaeng commented Aug 5, 2026

Uh oh!

coderabbitai Bot commented Aug 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Bananamilk452 commented Aug 1, 2026 •

edited

Loading

netlify Bot commented Aug 1, 2026 •

edited

Loading

coderabbitai Bot commented Aug 1, 2026 •

edited

Loading

codecov Bot commented Aug 1, 2026 •

edited

Loading