Repository navigation
docs: doc-review 2026-10-16 — automation execution location, RUM resolve mode, IM member auto-linking, CLI/SDK drift - #1062
Closed
flashduty[bot] wants to merge 1 commit into
Closed
flashduty[bot] wants to merge 1 commit into
flashduty[bot] wants to merge 1 commit into
Conversation
…lve mode, IM member auto-linking, CLI/SDK drift Window: 2026-10-15T08:00:13Z → 2026-10-16T08:12Z (previous successful run → this run). 28 findings from a diff-mode scan of 15 changed source repos + 5 submodule repos (5 high / 17 medium / 6 low); 27 applied in the docs repo, 1 recorded as a cross-repo follow-up for flashduty-website. - ai-sre: automation rules gained a create-time-fixed execution location (Web/IM), the run_in API field, IM-run session-identity stripping, the third skipped cause, and the IM execution-environment exception; IM page gains the third trigger path; attachment accordion gains the image fitting/40 MP rules. - on-call: removed aggregation-switch confirm dialog; literal wildcard matching + /.../ form and the stored-value migration; strict-grouping off-state rule (also on the channel wizard); DingTalk/Lark member auto-linking; Slack member linking removed from the docs because it never existed; new 2026-10-16 changelog block; comparison-page cells for IM-bound automations. - rum: new issue resolve mode (any/version) and the corrected reopen conditions. - cli / go-sdk: --run-in, --team-id inheritance, fixed-minute cron, install path and runner guard, monit folder-* commands, RuleFolders client, Automation run_in/TeamID. mint broken-links: success, no broken links found.
Contributor
|
Superseded by #1070, which re-applies the still-relevant parts of this PR on current main (see the table there for what was ported and what was left out). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doc Review — 2026-10-16
Mode: diff (since 2026-10-15T08:00:13Z)
Findings: 28 total — 5 high, 17 medium, 6 low
Window: previous successful run → this run. Source diffs were taken against the last first-parent
mainline commit before the window start of each repo (
git rev-list --first-parent -1 --before=… origin/main).Files changed in this PR: 34 (17 zh pages + their en counterparts, no new/renamed paths, no
docs.jsonchange).Changes
ai-sre/automations.mdxai-sre/automations.mdxrun_in/team_id字段表 + 「作用域与权限」新增 IM 执行位置一行ai-sre/automations.mdxtrigger_kind段与「立即执行」改写ai-sre/automations.mdxWeb 控制台改为Webai-sre/automations.mdxskipped改为三种情形并补chat_scope_mismatch原因行ai-sre/automations.mdxai-sre/im.mdxai-sre/sessions.mdxon-call/channel/noise-reduction.mdxon-call/configuration/filter-conditions.mdx/.../正则写法及存量值改写说明（含 routing-rules）on-call/channel/noise-reduction.mdxon-call/integration/instant-messaging/slack.mdxon-call/integration/instant-messaging/dingtalk.mdxon-call/integration/instant-messaging/lark.mdxrum/error-tracking/issue-status.mdxrum/error-tracking/error-viewing.mdxdeveloper/cli.mdxautomation create新增--run-in行与 IM 绑定创建说明developer/cli.mdx--team-id语义改为「省略即继承 IM 会话范围」developer/cli.mdx--cron-expr补分钟必须为固定 0–59 整数、最快每小时developer/cli.mdxflashduty所在目录，并补 runner 托管守卫developer/cli.mdxmonit folder-health/-create/-update/-move/-delete与返回结构说明developer/go-sdk.mdxclient.RuleFolders行与新增「规则分组」小节developer/go-sdk.mdxclient.Automations行与新增「AI SRE 自动化规则」小节changelog/changelog.mdxon-call/comparison/vs-pagerduty.mdxon-call/comparison/vs-opsgenie.mdxNEW: content/changelog/2026-10-16-<next-id>.mdxon-call/channel/create-edit.mdxReview checklist
zh/rum/error-tracking/issue-status.mdx: the 手动更新状态 screenshot still shows a 4-entry dropdown — it needs a new asset (the prose now lists all 5 options)<Update label="2026-10-16">block reads well next to the unmerged2026-10-15block in PR docs: doc-review 2026-10-15 — AI console page actions, AI-assisted noise reduction, service-calendar/CLI/SDK drift #1057 (same insertion point, an expected conflict on merge)Cross-repo follow-ups (flashduty-website)
NEW: content/changelog/2026-10-16-.mdx — flashduty-website has no changelog entry for the window's user-visible ships (IM-bound automations, RUM issue resolve mode / regression, IM member auto-linking); its newest pair of entries is dated 2026-10-05. Website entries are one dated .mdx plus a .zh.mdx sibling.
zh|en/openapi/api-catalog.mdxis stale (handed to the api-review automation, not edited here): it still says 「365 个接口」 and 「Monitors（41 个接口）」 and lists only/monit/folder/list, whileapi-reference/openapi.zh.jsonnow has 370 paths / 46 Monitors paths and the six/monit/folder/*routes became app_key-callable this window. The catalog enumeration andapi-reference/**are that automation's surface.Mapping warnings
flashduty-docs→zh|en/on-call/quickstart/comparison.mdx (derivative_surfaces.comparison_page.paths): the product comparison pages actually live at zh|en/on-call/comparison/vs-pagerduty.mdx and vs-opsgenie.mdx; the stale path silently disables the automatic comparison check, so this run checked those pages by hand insteadflashduty-docs→developer/mcp-server/ and developer/terraform/ (modules mcp-server and terraform, docs_path): the pages are files, not directories: zh|en/developer/mcp-server.mdx and zh|en/developer/terraform.mdx; set docs_path to the two-letter root ('developer/') or to the .mdx filefc-foundation-app→every src/Packages/* path in the mapping (saas, monit, rum, ai-sre, meow-ui): these are git submodules; their URLs in .gitmodules are SSH and cannot be initialised in the cloud sandbox, so the run diffs the standalone sibling clones (fc-saas-web, fc-saas-monit, fc-saas-rum, ai-sre-web, ai-assistant-web) instead and reports paths in the mapping's src/Packages/... form — expected, not stalenessSkipped
zh/rum/error-tracking/issue-alerts.mdx「Issue 重开」 row — the code does not contradict its wording (it never states the version condition), and the file is held by an open PR.Notes for reviewers (code-side, not doc issues)
go-flashdutyWriteDelete's generated comment claims deletion removes children/rules/dashboards, while the OpenAPI note forPOST /monit/folder/deletesays a non-empty folder returns 409FolderNotEmpty. Two writers hit this; the docs follow the 409 behaviour.fc-rumcmd/server/controller/issue/update.godefaultsresolve_modetoanywhen a client sendsstatus=resolvedwithout the field, while the DB/migration default for issues isversion. The console always sends it explicitly.fc-eventmigration/wildcard/rewrite.goskips values whose only regex metacharacters are parentheses or a lone dot (e.g.x(y)*), so those values silently change from regex to literal matching after the switch.