Skip to content

fix(access): Send login emails to the requested address - #233

Merged
nfebe merged 3 commits into
mainfrom
ui/branded-email-access-gate
Oct 9, 2026
Merged

nfebe merged 3 commits into
mainfrom
ui/branded-email-access-gate

Conversation

@nfebe

@nfebe nfebe commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Brand the deployment sign-in pages and send access links to the requested email address.

nfebe added 2 commits October 9, 2026 18:30
Visitors now see a consistent FlatRun identity before requesting access
and while waiting for the sign-in email.
@nfebe
nfebe force-pushed the ui/branded-email-access-gate branch from 18a8f2c to f16b595 Compare October 9, 2026 17:31
@sourceant

sourceant Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Code Review Summary

Deployment sign-in and email-confirmation pages now use shared FlatRun-branded HTML generated by a common accessPage helper instead of inline markup. Access links are now sent to the address the visitor typed: SendEmailTo strips any configured to/toAddresses query keys before setting the recipient. Version, changelog, and OpenAPI metadata move to 0.4.0-beta.10.

🚀 Key Improvements

  • Branded, responsive sign-in and confirmation pages share one accessPage template in internal/api/access_handlers.go.
  • internal/notify/notify.go now removes pre-existing to/toAddresses parameters so the requested recipient is used.

@sourceant sourceant Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review complete. See the overview comment for a summary.

@sourceant sourceant Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review complete. See the overview comment for a summary.

@nfebe
nfebe merged commit 9c2d262 into main Oct 9, 2026
6 checks passed
@nfebe
nfebe deleted the ui/branded-email-access-gate branch October 9, 2026 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant