Repository navigation
Point Launch App at the app publishing service - #167
Merged
Merged
Conversation
It linked to the GitHub repository. Fleetbase Cloud accounts now sign in with the account they're already using and land on their Storefront project; a self-hosted install goes to the page that explains the service. Cloud is told apart by the API host.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sidebar's Launch App linked to the
storefront-appGitHub repository. It now opens AppHelm, Fleetbase's service for publishing a store as a web and mobile app, in a new tab.api.fleetbase.io, read fromfetch.host, because the console has no existing Cloud flag.apphelm.fleetbase.io/storefront, which needs no sign-in. Anything else, including a missing host, takes this route.utm_tags, so signups from the console can be counted.en-us, the only language that has it. Other languages keep their "Launch App" label.Needs first
resume=1reopens an existing app, and comes from fleetbase/apphelm#44. Merge that first. Until then, each press creates another project.How it was checked
The URL function was run directly against Cloud hosts, self-hosted hosts, a lookalike host (
api.fleetbase.io.evil.com) and a missing host. New unit tests are added and the old assertion is updated. The Ember test suite wasn't run locally, so CI is the first run. The sidebar itself wasn't opened in a console.After merging
Reaching customers needs a package release of this module and a Cloud console update.