Skip to content

fix(ci): let composer resolve past the unpatched illuminate/mail advisory - #169

Merged
roncodes merged 1 commit into
release/v0.4.31from
fix/composer-mail-advisory
Nov 2, 2026
Merged

roncodes merged 1 commit into
release/v0.4.31from
fix/composer-mail-advisory

Conversation

@roncodes

@roncodes roncodes commented Nov 2, 2026

Copy link
Copy Markdown
Member

PHP CI has failed on every PR since Composer 2.11 at composer install, including README-only PRs. This is a stopgap to get it resolving while the Laravel upgrade is underway.

Cause

  • fleetbase/core-api requires illuminate/notifications ^9.0|^10.0, which needs illuminate/mail 9.x or 10.x.
  • Advisory PKSA-zwc5-qtrz-zm1n (CVE-2026-48019) covers all of those. Laravel only patched 12.60 and 13.10.
  • Composer blocks versions with advisories, so the tagged releases were already rejected. The resolver fell back to 10.x-dev, the only dev-branch package in the last green run.
  • That run used Composer 2.10.3. On 2.11.1, 10.x-dev is rejected too, so nothing is left to install. This repo has no composer.lock, and CI uses the latest Composer, so it picked this up on its own.

Fix

Ignores this one advisory ID for blocking, in config.policy.advisories:

  • Other advisories still block, unlike setting block: false.
  • composer audit still reports it, because of on-audit: false. Composer's docs describe these flags backwards; ListPolicyConfig and AdvisoriesPolicyConfig skip the advisory for an operation when its flag is true.
  • Consumers aren't affected, because config only applies to the root package.

illuminate/mail should now resolve to a tagged 10.x release instead of 10.x-dev.

What this doesn't fix

The vulnerability itself is still there until the Laravel upgrade lands. Remove this ignore as part of that upgrade.

Testing

CI on this PR is the test. Other open PRs need main merged in, or a re-run after this merges, to go green.

@roncodes
roncodes changed the base branch from main to release/v0.4.31 November 2, 2026 07:19
@roncodes
roncodes merged commit 6040027 into release/v0.4.31 Nov 2, 2026
9 checks passed
@roncodes
roncodes deleted the fix/composer-mail-advisory branch November 2, 2026 07:19
@codecov

codecov Bot commented Nov 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (af7d978) to head (f3baa45).
⚠️ Report is 8 commits behind head on release/v0.4.31.

Additional details and impacted files
@@                 Coverage Diff                 @@
##             release/v0.4.31      #169   +/-   ##
===================================================
  Coverage             100.00%   100.00%           
  Complexity              4014      4014           
===================================================
  Files                    229       229           
  Lines                  14221     14221           
===================================================
  Hits                   14221     14221           
Flag Coverage Δ
backend 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant