Repository navigation
fix(ci): let composer resolve past the unpatched illuminate/mail advisory - #169
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/v0.4.31 #169 +/- ##
===================================================
Coverage 100.00% 100.00%
Complexity 4014 4014
===================================================
Files 229 229
Lines 14221 14221
===================================================
Hits 14221 14221
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP CI has failed on every PR since Composer 2.11 at
composer install, including README-only PRs. This is a stopgap to get it resolving while the Laravel upgrade is underway.Cause
fleetbase/core-apirequiresilluminate/notifications ^9.0|^10.0, which needsilluminate/mail9.x or 10.x.PKSA-zwc5-qtrz-zm1n(CVE-2026-48019) covers all of those. Laravel only patched 12.60 and 13.10.10.x-dev, the only dev-branch package in the last green run.10.x-devis rejected too, so nothing is left to install. This repo has nocomposer.lock, and CI uses the latest Composer, so it picked this up on its own.Fix
Ignores this one advisory ID for blocking, in
config.policy.advisories:block: false.composer auditstill reports it, because ofon-audit: false. Composer's docs describe these flags backwards;ListPolicyConfigandAdvisoriesPolicyConfigskip the advisory for an operation when its flag istrue.configonly applies to the root package.illuminate/mailshould now resolve to a tagged 10.x release instead of10.x-dev.What this doesn't fix
The vulnerability itself is still there until the Laravel upgrade lands. Remove this ignore as part of that upgrade.
Testing
CI on this PR is the test. Other open PRs need
mainmerged in, or a re-run after this merges, to go green.