Repository navigation
Fix analyzer violations from Meziantou.Analyzer 3.0.299 - #149
Merged
Merged
Conversation
Use a semicolon body for the empty ITokenDecorator marker interface and replace First()/Last()/ElementAt() with indexers in tests, so the analyzer bump in the open Dependabot PRs builds cleanly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Dependabot PRs #147 and #148 bump Meziantou.Analyzer from 3.0.173 to 3.0.299, which fails the build on two rules we enable in
.editorconfig:ITokenDecoratoris an empty interface. It now uses a semicolon body.First()/Last()/ElementAt()calls in tests now use indexers. These were auto-fixed withdotnet format.I checked it locally with both analyzer versions. The build is clean and all 1762 tests pass. Once this is merged, rebase #147 and #148.