feat(firebase): tvOS support for firebase_crashlytics - #8
Open
TheNoumanDev wants to merge 1 commit into
Open
Conversation
Author
|
Hey @MAUstaoglu @DenisovAV — this adds |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds federated
firebase_crashlytics_tvos— Firebase Crashlytics for Apple TV, built on the Firebase Apple SDK. Re-exports thefirebase_crashlyticsDart API and ships the native tvOSpluginClass; depends onfirebase_core_tvos. Full Crashlytics API, no feature disables.Package(s) touched:
firebase_crashlytics_tvos(new)How was it tested?
Verified against a live Firebase project on both the tvOS simulator and a
physical Apple TV 4K (release/AOT):
initializeApp(options:)succeeds,[Firebase/Crashlytics] 12.15.0starts and fetches settings from…/platforms/tvos/gmp/<app-id>/settings, and a forcedFirebaseCrashlytics.instance.crash()was captured and reported to the Crashlytics console on both (uploaded tocrashlyticsreports-pa.googleapis.com, appeared as a crash issue).Platform.operatingSystem == "tvos"/Platform.isIOS == true.example/appdart analyzeis clean for the packageVersioning & changelog
version:set to0.0.1(new package)## 0.0.1entry at the top ofCHANGELOG.md0.x: initial0.0.1Checklist
firebase_crashlytics_tvosfiles are touchedTODO/debug leftoversREADME.mddocuments tvOS behaviour (no feature limitations; version-alignment note)Notes for reviewers
_tvosleaf packages): the native code matchesfirebase_crashlytics 5.2.4on thefirebase_core_platform_interface7.1.0 train (firebase_core 4.11.x) — this is the latest Crashlytics on that train (5.2.7+ moves tofirebase_core 4.13.0/platform_interface 8.1.0, which the publishedfirebase_core_tvosisn't built for).Firebase/Crashlytics+firebase_core_tvos, tvOS 15,LIBRARY_NAMEdefines);<firebase_core/…>imports repointed to<firebase_core_tvos/…>; Dart re-export.