Repository navigation
Conversation
|
|
garlick
reviewed
Nov 6, 2026
garlick
left a comment
garlick
left a comment
Member
There was a problem hiding this comment.
I think an exec continued response will be needed for attach too.
Also, should we mention that a STOP immediately followed by a CONT and vice versa may be suppressed, as in posix SIGCONT handling (with reference)?
Member
Author
I did think about that, but figured it was an implementation choice and not something the protocol should define? |
Problem: Presently a response to indicate a subprocess has received a SIGCONT signal is not supported. Add a new "exec continued" response to support this reporting.
Member
Author
re-pushed, adding the attach part too. |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: Presently a response to indicate a subprocess has received a SIGCONT signal is not supported.
Add a new "exec continued" response to support this reporting.
This is to match work in flux-framework/flux-core#7842