Skip to content

Bump diff to 8.0.4 for CVE-2026-24001 - #156

Merged
kylemclaren merged 2 commits into
fly-apps:mainfrom
alexleventer:bump-diff-cve
Oct 22, 2026
Merged

kylemclaren merged 2 commits into
fly-apps:mainfrom
alexleventer:bump-diff-cve

Conversation

@alexleventer

@alexleventer alexleventer commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #145.

Problem

@flydotio/dockerfile depends on diff@^7.0.0, which is affected by CVE-2026-24001, a DoS in parsePatch/applyPatch (patched in 8.0.3). This package only calls Diff.createPatch (gdf.js, to show conflicts), so it isn't exploitable here, but npm audit and other scanners flag every install.

Change

  • Bump diff to ^8.0.4.
  • Update mocha's nested copy of diff from 5.2.0 to 5.2.2 (the patched 5.x) in package-lock.json. It's a dev dependency, but scanners flag it too.

The lockfile also picks up its stale root version catching up to package.json (0.7.8 → 0.7.11).

diff 8 is still dual ESM/CJS with no Node engine bump (>=0.3.1), so the existing import * as Diff from 'diff' works unchanged.

Testing

  • npm audit no longer reports diff.
  • createPatch gives the same unified diff output on 8.0.4.
  • eslint clean. npm test: 126 passing, 3 failing (bun base/cache-bun, svelte-bun), the same 3 that fail on main without bun installed.

🤖 Generated with Claude Code

@kylemclaren
kylemclaren merged commit aaa2e4e into fly-apps:main Oct 22, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dependency diff (jsdiff) has DoS vulnerability (CVE-2026-24001)

2 participants