Repository navigation
Bump diff to 8.0.4 for CVE-2026-24001 - #156
Merged
Merged
Conversation
kylemclaren
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #145.
Problem
@flydotio/dockerfiledepends ondiff@^7.0.0, which is affected by CVE-2026-24001, a DoS inparsePatch/applyPatch(patched in 8.0.3). This package only callsDiff.createPatch(gdf.js, to show conflicts), so it isn't exploitable here, butnpm auditand other scanners flag every install.Change
diffto^8.0.4.difffrom 5.2.0 to 5.2.2 (the patched 5.x) inpackage-lock.json. It's a dev dependency, but scanners flag it too.The lockfile also picks up its stale root version catching up to
package.json(0.7.8 → 0.7.11).diff8 is still dual ESM/CJS with no Node engine bump (>=0.3.1), so the existingimport * as Diff from 'diff'works unchanged.Testing
npm auditno longer reportsdiff.createPatchgives the same unified diff output on 8.0.4.eslintclean.npm test: 126 passing, 3 failing (bun base/cache-bun, svelte-bun), the same 3 that fail onmainwithout bun installed.🤖 Generated with Claude Code