Repository navigation
New Mellea post on LintQ for IVR - #80
Conversation
|
Hi @gretadolcetti - thanks for blog post. great to have a quantum example. Just two quick things a) I noticed the description stopped after 'Presents experimental results on Qiskit HumanEval (hard) and' - not a big deal but you might have wanted to put more b) You need to 'signoff' on your commits. this is why DCO is failing. Since you only have one commit it's fairly easy to add it (for example read here Will take a read |
Signed-off-by: Greta <gretadolcetti@gmail.com>
|
Hi @planetf1, thanks for the feedback! I should have fixed both aspects. |
planetf1
left a comment
There was a problem hiding this comment.
Thanks @gretadolcetti! I tried running the code (macOS, mellea 0.8.0) and left a few comments inline.
Signed-off-by: Greta <gretadolcetti@gmail.com>
Signed-off-by: Greta <gretadolcetti@gmail.com>
Signed-off-by: Greta <gretadolcetti@gmail.com>
Signed-off-by: Greta <gretadolcetti@gmail.com>
Signed-off-by: Greta <gretadolcetti@gmail.com>
|
Thanks @planetf1 for the very quick and detailed review! I believe I’ve addressed all your concerns in the latest fixes. Most of them stemmed from the fact that I intended the blog post not as a directly runnable example but as a didactic one, with pointers to the real code (in generative-computing/mellea#1716), where users can run it themselves and experiment, building on @ajbozarth’s existing example. That said, I think your comments have improved the blog post a lot! |
ajbozarth
left a comment
There was a problem hiding this comment.
Review generated by Claude. I'll do a separate manual pass through the blog myself.
Thanks @gretadolcetti — this is a great use of IVR, and a fun one to see written up. The code lines up with the current mellea APIs and the Results numbers match the example's benchmarking, so no concerns on accuracy.
Before this merges: the mellea example this links to may not include the LintQ code (see generative-computing/mellea#1716), so let's make sure the post doesn't depend on it — details inline. A few small copy nits inline as well.
Co-authored-by: Alex Bozarth <ajbozart@us.ibm.com> Signed-off-by: Greta Dolcetti <53076361+gretadolcetti@users.noreply.github.com>
Co-authored-by: Alex Bozarth <ajbozart@us.ibm.com> Signed-off-by: Greta Dolcetti <53076361+gretadolcetti@users.noreply.github.com>
Co-authored-by: Alex Bozarth <ajbozart@us.ibm.com> Signed-off-by: Greta Dolcetti <53076361+gretadolcetti@users.noreply.github.com>
Signed-off-by: Greta <gretadolcetti@gmail.com>
Signed-off-by: Greta <gretadolcetti@gmail.com>
|
Hi @ajbozarth, thanks for the feedback and suggestions! |
ajbozarth
left a comment
There was a problem hiding this comment.
Review from Claude — the broken paragraph below came from a mis-anchored suggestion in Claude's earlier review, not your edits. Apologies for the churn.
The LintQ-paper citation and the CodeHelm note both look right. One leftover to fix, inline.
ajbozarth
left a comment
There was a problem hiding this comment.
Review from Claude.
One suggestion on the paper citation, inline.
Co-authored-by: Alex Bozarth <ajbozart@us.ibm.com> Signed-off-by: Greta Dolcetti <53076361+gretadolcetti@users.noreply.github.com>
Co-authored-by: Alex Bozarth <ajbozart@us.ibm.com> Signed-off-by: Greta Dolcetti <53076361+gretadolcetti@users.noreply.github.com>
|
@gretadolcetti — this PR is scheduled to merge on |
|
I do believe this looks good pending what happens with generative-computing/mellea#1716, either way we'll need to update the release date, I would suggest updating it to next Monday for now |
Signed-off-by: Greta Dolcetti <53076361+gretadolcetti@users.noreply.github.com>
|
Thanks @ajbozarth for the positive review, I updated the release date to Monday 19th of October. |
|
@gretadolcetti — this PR is scheduled to merge on |
3 similar comments
|
@gretadolcetti — this PR is scheduled to merge on |
|
@gretadolcetti — this PR is scheduled to merge on |
|
@gretadolcetti — this PR is scheduled to merge on |
|
I've removed the remind from the description so the bot stop posting everyday. I am still actively reviewing both this and more so the example PR to actually test run them manually and validate the readme and blog steps (slow due to low bandwidth). Once the other PR is merged we can update the date on this and release it. |
ajbozarth
left a comment
There was a problem hiding this comment.
Per my recent comment on the example PR generative-computing/mellea#1716 (comment) I think we can unblock this with some minor tweaks and post it tomorrow.
And sorry for the delays in reviewing the PRs
|
|
||
| ```python | ||
| from mellea.stdlib.requirements import req, simple_validate | ||
| from validation_helpers import extract_code_from_markdown, validate_correctness, validate_lintq |
There was a problem hiding this comment.
not a huge issue given you define it in a code block below, but technically validate_lintq won't be in validation_helpers after addressing my review in the example PR. We can probably leave it as is, but if you have a better way of writing the import it may be clearer to a reader
Co-authored-by: Alex Bozarth <ajbozart@us.ibm.com> Signed-off-by: Greta Dolcetti <53076361+gretadolcetti@users.noreply.github.com>
Signed-off-by: Greta Dolcetti <53076361+gretadolcetti@users.noreply.github.com>
|
Perfect, @ajbozarth. I should have addressed all of your last comments. |
a9206e0
This pull request adds a new blog post, "Tests Pass, Smells Stay: Adding a Quantum Linter to Qiskit IVR," which describes integrating the LintQ quantum linter into the Mellea Instruct-Validate-Repair (IVR) loop for Qiskit code generation. The post explains how quantum-specific code smells can persist even after passing all tests and demonstrates how combining functional testing with quantum-aware static analysis significantly increases the share of generated programs that are both correct and free of quantum code smells.
Key additions and themes:
New Content: Quantum Linting in IVR
Validation Pipeline and Implementation
Results and Impact