Repository navigation
Conversation
… dependencies and streamlining SentryCronJobListener options handling
…and update Quartz integration
… collection parameter and streamlining option configuration
…dSentryScope method, update SentryMetricsMiddleware to support configurable options
The format-code workflow can't push its auto-fix to a fork branch, so it fails the check instead. Applying the fix here. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Every package needs a name/packageUrl/mainDocsUrl entry so craft can create its registry entry on first publish; a missing `name` fails the whole registry target rather than just that package. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…lug attribute Quartz logs a job's exception only after the middleware chain has returned, so the logged error lost the job's scope and trace. Capture it inside the scope again; the SDK drops the duplicate from the log. Rename SentryCronMonitorSlugAttribute to SentryMonitorSlugAttribute to match Sentry.Hangfire. Co-Authored-By: Claude <noreply@anthropic.com>
The AddSentry() remarks still said job exceptions are left to the logging integration. The scope middleware has captured them again since 73e5551. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MonitorAllJobs sends check-ins for every job fired by a cron trigger or a repeating simple trigger, with the slug of the job's key. ExcludedJobs skips jobs by name, full key or regex. Jobs with SentryMonitorSlug keep their settings. Co-Authored-By: Claude <noreply@anthropic.com>
1 of 3 tasks
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5741 +/- ##
=======================================
Coverage 76.13% 76.13%
=======================================
Files 528 528
Lines 19579 19603 +24
Branches 3829 3840 +11
=======================================
+ Hits 14906 14925 +19
- Misses 3791 3792 +1
- Partials 882 886 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…schedules Reads every monitored trigger, cached for a minute, like Sentry.Hangfire. Replaces the check for jobs with several triggers.
wedamija
marked this pull request as ready for review
October 20, 2026 17:29
A job without an identity has fallen back to its class name with a debug message, not a warning, since fe97276. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Picks up #5757, which fixes the Blazor WASM E2E job on Ubuntu 26.04 runners. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Jobs that MonitorAllJobs covers now count in the shared slug check, so a job with several triggers on different schedules still drops the schedule, and their triggers stay in the cached lookup. Co-Authored-By: Claude <noreply@anthropic.com>
…gers A job left in a persistent store after its class was renamed or deleted made the whole trigger read throw, so no monitored job sent its schedule. Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
…aptured Co-Authored-By: Claude <noreply@anthropic.com>
…tion on Quartz's ErrorLogger logs the exception again, wrapped in a JobExecutionProcessException that the default DeduplicateMode doesn't unwrap. AddSentry now adds a log entry filter for that entry, to whichever SentryLoggingOptions the app uses (SentryAspNetCoreOptions included), when the middleware captured the inner exception. Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Co-authored-by: Ricardo Colombo Oliveira <github@ricoliv.com>
…log filter setup Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of a series adding automatic Crons monitoring for the most-used job schedulers in each SDK. Check-ins for a monitor that doesn't exist yet are dropped, so today each monitor has to be created by hand with its schedule copied from the code. Sending the job's schedule as the monitor config lets Sentry create the monitor and keep it in sync.
This adds
SentryQuartzOptions.MonitorAllJobs, which monitors every scheduled job without adding[SentryMonitorSlug]to each job class, andExcludedJobsto skip some by name, full key or regex. The monitor slug comes from the job key. Jobs with[SentryMonitorSlug]keep their own settings. Off by default.Only runs fired by a cron trigger or a repeating simple trigger are monitored, so one-off runs like
TriggerJobare skipped. Schedules Sentry can't represent, triggers with a calendar and jobs with several triggers check in without a config.Stacked on #5505, through the
danf/quartz-5505-rebasedbranch since that PR's head is on a fork.