Repository navigation
Conversation
On the build legs, the unit tests and the integration tests run one after the other, though the integration tests only need the packages. On win-x64 the Test step takes 5.8 minutes and Integration test 14. Outside the publishing build, Test now runs as a background step. The job packs and runs the integration tests next to it, then waits for it before uploading coverage. The macOS publishing build keeps the current order, because its sparse checkout removes the test outputs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Every solution build runs before.Sentry.sln.targets, which calls git submodule update --init --recursive. With the tests in the background, dotnet test and dotnet pack started in the same second on linux-x64, and the second git call failed on the lock for a submodule's config file, so the tests failed before they ran. Packing takes under a minute, so the tests now start once it's done. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A throwaway, not for merging. One test always fails, and one Verify test has no approved snapshot, so CI shows how a failing background test step surfaces and whether the received snapshot gets uploaded. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This draft is only here to check #5785's failure path. Please don't review or merge it. I'll close it and delete the branch once the run finishes.
It's #5785's branch plus two tests in
Sentry.Serilog.Teststhat fail on purpose. One always fails, and one Verify test has no approved snapshot, so it writes a.received.txtfile. They're inSentry.Serilog.Testsso the device test workflows don't start.On the legs that run the unit tests in the background, I want to see:
#skip-changelog