docs: clarify macOS dependencies - #13498
Conversation
reword: The doc said "macOS doesn't need any dependencies" and then immediately listed things you needed to install for macOS 😁. This is just rewording the doc to be more consistent.
ghostty-bot
Bot
added
the
documentation
|
Hi @vegerot, thanks for your interest in contributing! This project requires that pull request authors are vouched, and you are not in the list of vouched users. This PR will be closed automatically. See https://github.com/ghostty-org/ghostty/blob/main/CONTRIBUTING.md for more details. |
There was a problem hiding this comment.
Pull request overview
This PR updates HACKING.md to make the “Extra Dependencies” section consistent by replacing a contradictory macOS statement (“no additional dependencies”) with platform-specific subsections.
Changes:
- Split “Extra Dependencies” into explicit
### Linuxand### macOSsubsections. - Removed the contradictory macOS sentence and kept the Xcode/SDK requirement text under the new macOS subsection.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Fair enough, I meant like outside of standard build environments (e.g. I don't list the compiler an extra dep on Linux either). But I can see how this is confusing. |
|
!vouch |
Triggered by [comment](#13498 (comment)) from @mitchellh. Vouch: @vegerot Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
reword: The doc said "macOS doesn't need any dependencies" and then immediately listed things you needed to install for macOS 😁. This is just rewording the doc to be more consistent.